Project

General

Profile

Actions
Copy link

Feature #3158

closed

Assign role to account

Added by Roman Kučera almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Peter Štrunc
Category:
Technical and other accounts
Target version:
13.0.0
Start date:
06/27/2022
Due date:
% Done:

100%

Estimated time:
500.00 h
Owner:

Description

Junction table for account roles
BE only, tests

We need to check every place in IdM where IdentityRole is used and make the decision if we need to port it to account role

Related issues

Blocks IdStory Identity Manager - Feature #3153: Add support for technical and other account in role requestClosedPeter Štrunc06/27/2022

Actions
Blocks IdStory Identity Manager - Feature #3150: Other account requestClosedRoman Kučera06/27/2022

Actions
Blocks IdStory Identity Manager - Feature #3149: Technical account requestClosedRoman Kučera06/27/2022

Actions
Actions
Copy link
 #1

Updated by Roman Kučera almost 2 years ago

  • Blocks Feature #3153: Add support for technical and other account in role request added
Actions
Copy link
 #2

Updated by Roman Kučera almost 2 years ago

Actions
Copy link
 #3

Updated by Roman Kučera almost 2 years ago

Actions
Copy link
 #4

Updated by Tomáš Doischer over 1 year ago

  • Sprint set to Sprint 12.3-1 (srp 03 - srp 17)
  • Assignee set to Peter Štrunc
Actions
Copy link
 #5

Updated by Peter Štrunc over 1 year ago

  • Status changed from New to In Progress
Actions
Copy link
 #6

Updated by Tomáš Doischer over 1 year ago

  • Sprint changed from Sprint 12.3-1 (srp 03 - srp 17) to Sprint 12.3-2 (srp 17 - srp 31)
Actions
Copy link
 #7

Updated by Peter Štrunc over 1 year ago

  • % Done changed from 0 to 70

I finished refactoring and have a basic green line of adding/removing and updating account role assignments ready. I did a LOT of refactoring in order to enable us to abstract role assignment handling logic and possibly add more types in future.

This ticket is for from finished, but we decided to review it in parts because there are a lot of changes to review. I created merge request here https://github.com/bcvsolutions/CzechIdMng/pull/258. Would you please look at it @doischert ?

Some things that are yet to be done:

  • REST controllers for acc role assignments
  • RoleValidRequests are still only working with IdentityRoles
  • Add more tests
  • Cleanup code
Actions
Copy link
 #8

Updated by Tomáš Doischer over 1 year ago

  • Sprint changed from Sprint 12.3-2 (srp 17 - srp 31) to Sprint 12.3-3 (srp 31 - zář 14)
Actions
Copy link
 #9

Updated by Tomáš Doischer over 1 year ago

I checked the code and have very minor notes. It looks great. Once the tests are in better shape, we can merge to develop.

Actions
Copy link
 #10

Updated by Tomáš Doischer over 1 year ago

  • Sprint changed from Sprint 12.3-3 (srp 31 - zář 14) to Sprint 12.3-4 (zář 14 - zář 28)
Actions
Copy link
 #11

Updated by Tomáš Doischer over 1 year ago

  • Sprint changed from Sprint 12.3-4 (zář 14 - zář 28) to Sprint 12.3-5 (zář 28 - říj 12)
Actions
Copy link
 #12

Updated by Tomáš Doischer over 1 year ago

Some further implementation to add:

  • evaluators for account roles actions: for the account owner, system owner, account owner's manager, technical account guarantor for technical accounts
  • remove account roles after account delete
Actions
Copy link
 #13

Updated by Tomáš Doischer over 1 year ago

  • Sprint changed from Sprint 12.3-5 (zář 28 - říj 12) to Sprint 12.3-6 (říj 12 - říj 26)
Actions
Copy link
 #14

Updated by Tomáš Doischer over 1 year ago

  • Sprint changed from Sprint 12.3-6 (říj 12 - říj 26) to Sprint 12.3-7 (říj 26 - lis 09)
Actions
Copy link
 #15

Updated by Tomáš Doischer over 1 year ago

  • Sprint changed from Sprint 12.3-7 (říj 26 - lis 09) to Sprint 12.3-8 (lis 09 - lis 23)
Actions
Copy link
 #16

Updated by Tomáš Doischer over 1 year ago

  • Sprint changed from Sprint 12.3-8 (lis 09 - lis 23) to Sprint 12.3-9 (lis 23 - pro 07)
Actions
Copy link
 #17

Updated by Tomáš Doischer over 1 year ago

I reviewed the code, see the PR for comments (all minor). Tests are not passing. I haven't yet tested it in GUI.

Actions
Copy link
 #18

Updated by Ondřej Kopr over 1 year ago

  • Estimated time changed from 40.00 h to 500.00 h
Actions
Copy link
 #20

Updated by Tomáš Doischer over 1 year ago

  • Sprint changed from Sprint 12.3-9 (lis 23 - pro 07) to Sprint 12.3-10 (pro 07 - pro 21)
Actions
Copy link
 #21

Updated by Tomáš Doischer over 1 year ago

  • Status changed from In Progress to Resolved
  • % Done changed from 70 to 100

Merged to develop.

Actions
Copy link
 #22

Updated by Tomáš Doischer about 1 year ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF