Project

General

Profile

Actions

Defect #3100

closed

Execution of update script is driven by create checkbox

Added by Luboš Čábelka over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Roman Kučera
Target version:
Start date:
04/07/2022
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

When you have selected checkboxes in configuration
Config___Create via WinRM connector (Powershell)
Config___Update via AD connector

for create operation is used WinRM, but for update opeation is again used WinRM. Because both create and update methods calls: executeAdThenWinrm(), executeWinrmThenAd(), executeOnlyAd() and executeOnlyWinrm() which checks configuration only for create operation.

Delete operation looks into configuration directly.

Change of behavior is in commit: https://github.com/bcvsolutions/winrm-ad-connector/commit/9f85eb18973f4bf8f14bd3f0eb507533c23ed5a3

Actions #1

Updated by Luboš Čábelka over 2 years ago

  • Status changed from New to In Progress
  • Assignee changed from Roman Kučera to Luboš Čábelka
Actions #2

Updated by Luboš Čábelka over 2 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Luboš Čábelka to Roman Kučera
  • % Done changed from 0 to 90

Fixed in commit https://github.com/bcvsolutions/winrm-ad-connector/commit/b107e9b8a1ccffbaeec70258057228a3198a600f

Create, update and delete operation now uses same logic

Deployed on project 7.4, connector is in use in test environment for almost month.

Actions #3

Updated by Roman Kučera over 2 years ago

Thx for fix, LGTM.
Merged into develop, will be released today.

Actions #4

Updated by Roman Kučera over 2 years ago

  • Status changed from Needs feedback to Closed
  • % Done changed from 90 to 100

released

Actions #5

Updated by Roman Kučera over 2 years ago

  • Target version set to 1.0.9
Actions

Also available in: Atom PDF