Actions
Defect #3099
closed
Generator type column on Generate values agenda can't be localized from other module then core
Start date:
04/07/2022
Due date:
% Done:
100%
Estimated time:
Description
When you use generator from some other module then core, then localization in column Generator type is not working.
You will see only localization key in this column, the issue is in the way how the localization is displayed
https://github.com/bcvsolutions/CzechIdMng/blob/ca7386f00c5038802d62b9a0d42044302bf89cc0/Realization/frontend/czechidm-core/src/content/generatevalues/GenerateValueTable.js#L200
Files
Updated by Roman Kučera over 2 years ago
Localization for generator detail (parameters) is working correctly.
Updated by Tomáš Doischer over 2 years ago
- Status changed from New to Needs feedback
- Assignee changed from Tomáš Doischer to Roman Kučera
- Target version set to 13.0.0
- % Done changed from 0 to 80
PR: https://github.com/bcvsolutions/CzechIdMng/pull/226
Can you please give me feedback, @kucerar?
Updated by Tomáš Doischer over 2 years ago
- Sprint set to Sprint 12.3-1 (srp 03 - srp 17)
Updated by Roman Kučera over 2 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Roman Kučera to Tomáš Doischer
Look at comment in PR.
The code from PR didn't work for me.
Updated by Tomáš Doischer over 2 years ago
- Sprint changed from Sprint 12.3-1 (srp 03 - srp 17) to Sprint 12.3-2 (srp 17 - srp 31)
Updated by Tomáš Doischer over 2 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Tomáš Doischer to Roman Kučera
Thanks for the feedback, your suggested solution works for me.
Can you look at it again?
Updated by Roman Kučera over 2 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Roman Kučera to Tomáš Doischer
- % Done changed from 80 to 100
LGTM, thx, merged
Updated by Tomáš Doischer almost 2 years ago
- Status changed from Resolved to Closed
Actions