Project

General

Profile

Actions

Task #3090

closed

When repeatedly removing a business role, prevent repeated creating of removal tasks

Added by Tomáš Doischer about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomáš Doischer
Category:
Roles
Target version:
Start date:
03/28/2022
Due date:
% Done:

100%

Estimated time:
Owner:

Description

When a business role is deleted, this happens asynchronously and it takes time. The user can then try to remove the business role again. This again leads to the creation of a business role removal task. This task does nothing, it doesn't lead to exceptions but it fills up the task overview.

Actions #1

Updated by Tomáš Doischer about 2 years ago

  • Assignee changed from Roman Kučera to Tomáš Doischer
  • Target version set to 12.2.0
Actions #2

Updated by Tomáš Doischer about 2 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Tomáš Doischer to Roman Kučera

Simple implementation. I just check if any role composition removal task is running with the same role composition and if so, I don't start the LRT.

I don't throw any exceptions, I just let the user click as much as they want. This removal should preferably be presented in a better way to the user but an exception is not right the solution.

PR: https://github.com/bcvsolutions/CzechIdMng/pull/197

@kucerar, can you please give me feedback?

Actions #3

Updated by Tomáš Doischer about 2 years ago

  • % Done changed from 0 to 100
Actions #4

Updated by Roman Kučera about 2 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Roman Kučera to Tomáš Doischer

LGTM, thx for fix.
I added one suggestion to PR about stream noneMatch(), but you don't have to change the code.

Actions #5

Updated by Roman Kučera about 2 years ago

merged into develop

Actions #6

Updated by Roman Kučera almost 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF