Project

General

Profile

Actions

Defect #3024

closed

Task from some other module can't be disapproved

Added by Roman Kučera over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Roman Kučera
Category:
Frontend
Target version:
Start date:
12/21/2021
Due date:
% Done:

100%

Estimated time:
Owner:

Description

It was found on crt module, but it can happen in some other projspec modules to.
Because of some changes about decision reason in IdM 11.1.0 crt request can't be denied.
When you click disapprove and want to confirm it with "yes" button nothing will heppen.
In browser console you can see error
uncaught TypeError: Cannot read properties of undefined (reading 'isFormValid')

Error is in DynamicTaskDetail::validateDecisionReason because decisionForm is undefinied
Add some condition that in case decision reason is not turned don't validate it.


Related issues

Related to Certificate Authority (crt) - Task #3023: Request can't be disapproved on IdM >= 11.1.0ClosedRoman Kučera12/21/2021

Actions
Actions #1

Updated by Peter Štrunc over 2 years ago

  • Target version set to 12.2.0
Actions #2

Updated by Peter Štrunc about 2 years ago

  • Target version changed from 12.2.0 to 13.0.0
Actions #3

Updated by Peter Štrunc about 2 years ago

  • Target version changed from 13.0.0 to 12.2.0
Actions #4

Updated by Roman Kučera about 2 years ago

  • Status changed from New to In Progress
  • Assignee changed from Peter Štrunc to Roman Kučera
Actions #5

Updated by Roman Kučera about 2 years ago

  • Related to Task #3023: Request can't be disapproved on IdM >= 11.1.0 added
Actions #6

Updated by Roman Kučera about 2 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Roman Kučera to Tomáš Doischer
  • % Done changed from 0 to 80

https://github.com/bcvsolutions/CzechIdMng/pull/202

@doischert Can you do a review please? I can show you the replicate task on my env if its help you.

Actions #7

Updated by Tomáš Doischer about 2 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Tomáš Doischer to Roman Kučera
  • % Done changed from 80 to 100

Thank you, LGTM, merged to develop.

Actions #8

Updated by Roman Kučera almost 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF