Project

General

Profile

Actions

Task #2982

closed

Only subroles from property business role are processed

Added by Luboš Čábelka over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Luboš Čábelka
Target version:
Start date:
10/19/2021
Due date:
% Done:

100%

Estimated time:
Owner:

Description

When you have business role with property and some subroles, only subroles are processed when creating new role request. Main role is skipped.

Actions #2

Updated by Tomáš Doischer over 2 years ago

  • Status changed from New to In Progress
  • Target version set to 1.0.2
Actions #3

Updated by Tomáš Doischer over 2 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Tomáš Doischer to Luboš Čábelka
  • % Done changed from 0 to 80

Fixed, I added a test for this condition as well:

Commit (fix): https://git.bcvsolutions.eu/modules/property/-/commit/c8b726af24b63cdaf3efc9a059d7aacfb2814871
Commit (test): https://git.bcvsolutions.eu/modules/property/-/commit/83965c471ba024fa2c11bc02dfe72546618eaa40

@lubos.cabelka@bcvsolutions.eu, can you give me feedback?

Actions #4

Updated by Luboš Čábelka over 2 years ago

  • Status changed from Needs feedback to Resolved
  • % Done changed from 80 to 100

Code and tests looks good.
I tested fix on my local environment where I confirmed bug and it works now.
Property from top role OK.
Property from subrole OK.
Property from role without composition OK.

Actions #5

Updated by Tomáš Doischer over 2 years ago

  • Status changed from Resolved to Closed

Released.

Actions

Also available in: Atom PDF