Task #2837
closed
Improve the LastContractEndNotificationTask
100%
Description
This task is stateful, so the notification is not sent multiple times for the same contract. This needs to be configurable because it can happen that the contract's validity is extended and then the notificitation will not be sent at the moment.
Another requirement is to add the option to not send the notification if the identity is manually disabled.
Updated by Tomáš Doischer almost 3 years ago
- Status changed from New to Needs feedback
- % Done changed from 0 to 80
Implemented in branch: https://github.com/bcvsolutions/czechidm-extras/compare/doischer/2837-improve-last-contract-notification?expand=1
You can now select that the notification shouldn't be sent when the identities are manually disabled.
The task will now clean its queue if the contract's validity is extended.
Tests were added and documentation updated.
Updated by Tomáš Doischer almost 3 years ago
- Assignee changed from Tomáš Doischer to Alena Peterová
@apeterova, can you please give me feedback?
Updated by Alena Peterová almost 3 years ago
- Assignee changed from Alena Peterová to Tomáš Doischer
I made the feedback and tested the function, it works great, thanks.
The documentation in https://wiki.czechidm.com/tutorial/adm/notification_-_identity_s_last_contract_is_ending#set_up_the_long_running_task_lrt is sufficient, I only uploaded a new screenshot as I will need it also in my admin tutorial.
Note from testing: When using the dry run, all items are marked as not_executed without the distinction which would be handled by the LRT and which not. But probably this is nothing new. Also, even in dry run, the old items may be deleted from the queue if they should no longer be there. However, the same behavior is for HR processes.
Updated by Tomáš Doischer almost 3 years ago
- Status changed from Needs feedback to Resolved
- % Done changed from 80 to 100
Merged to develop.
Updated by Peter Štrunc almost 3 years ago
- Status changed from Resolved to Closed