Task #2795
closed
Remove bulk action for role-request agenda
100%
Description
Please add support for bulk actions to the role request agenda. Implement only bulk action for remove now.
Updated by Ondrej Husník almost 3 years ago
- Status changed from New to In Progress
Updated by Ondrej Husník almost 3 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Vít Švanda
- % Done changed from 80 to 90
Bulk action support is added to role request and the delete action is created.
Would you provide me a feedback, please?
https://github.com/bcvsolutions/CzechIdMng/commit/e61a34f68e9ed45f9eb8f9672976efa24de8e650
Updated by Vít Švanda almost 3 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Vít Švanda to Ondrej Husník
I did review. Delete bulk action works well, but maybe too much well. In the delete bulk action must be implemented logic from IdmRoleRequestController.delete.
Updated by Ondrej Husník almost 3 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Vít Švanda
Thank you very much for your careful review. I missed the fact that there was some logic implemented in the controller. It is moved into bulk action which is now also invoked in the controller.
I also added tests. Please recheck it again for me. Thank you.
https://github.com/bcvsolutions/CzechIdMng/commit/c797e6c6f2d590afd87aad29c39917c939e68978
Updated by Vít Švanda almost 3 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Ondrej Husník
- % Done changed from 90 to 100
I did rereview and retested it. Works well now. I found problem with missing checkAccess on delete in the bulk action.
I completed this in this commit: https://github.com/bcvsolutions/CzechIdMng/commit/515d42a204806a5dfd45c2c571e1f9a22a37c3c4
Updated by Radek Tomiška almost 3 years ago
- Status changed from Resolved to Closed