Task #2703
closed
Set same password to all systems for new identity.
100%
Related issues
Updated by Radek Tomiška almost 4 years ago
- Related to Task #666: Set one password to all systems when creating identity. added
Updated by Vít Švanda almost 4 years ago
- % Done changed from 70 to 80
Common password feature implemnted. Async tests created. Code is in the develop. Documentation remains to do.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/345cc829a19a45106f35088cfbd6437bc3090fe1
Updated by Vít Švanda over 3 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 80 to 90
Updated by Vít Švanda over 3 years ago
I moved the UniformPasswordManager from Core to ACC module, because tests are in ACC module (coverage). I implemented test cleaner in ACC teset helper for unstable tests.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/bc55df04eb0b0f22c6e191d7b3a058bf948ca069
Updated by Vít Švanda over 3 years ago
- Related to Task #2744: Uniform password for new accounts - connect to the Uniform password agenda (and support set password to an identity) added
Updated by Radek Tomiška over 3 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Vít Švanda
I did test and code review, it works smoothly and code is nice, thx for reverting formating in "my classes" :). New api methods for manual events are better than expose internal event cache, nice.
Review notes:
- RoleRequestNotifyProvisioningProcessorIntegrationTest is not passing (works without added helper.cleaner()). Test fails locally and on jenkins too.
- DefaultCommonPasswordManager - @Transactional annotations missing (mainly for endCommonPasswordProcess method, where states are deleted in cycle ~ more active operations than one).
Updated by Vít Švanda over 3 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Vít Švanda to Radek Tomiška
You are right. The test RoleRequestNotifyProvisioningProcessorIntegrationTest didn't pass. It is strange, because I added cleaner because this test didn't pass in past. So I removed the cleaner as you said and not all tests works.
I added Transaction annotations too.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/4fc6bc9e32d413df4fd3d604273677e7ac72b137
https://github.com/bcvsolutions/CzechIdMng/commit/f5ae69d004c6d57441bfcf8a8a0bf3f3cda2fb15
Updated by Radek Tomiška over 3 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 90 to 100
Nice, thx!
Updated by Radek Tomiška over 3 years ago
- Status changed from Resolved to Closed