Project

General

Profile

Actions
Copy link

Task #2561

closed

Enable case insensitive activation of users

Added by Tomáš Doischer about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomáš Doischer
Target version:
2.3.2
Start date:
11/05/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

The goal is to add a new configuration property which would enable case insensitive find in DefaultRegIdentityService.findIdentity. This can be useful - if the identity in IdM has email "" but the user tries to activate the account with email "", it is not possible to activate the account.

Actions
Copy link
 #1

Updated by Tomáš Doischer about 4 years ago

  • % Done changed from 0 to 50

The implementation is in branch: https://git.bcvsolutions.eu/modules/reg/-/commits/doischer/2561-case-insensitive-find
The branch is based on tag 2.3.1.

Documentation was updated.

To-do: tests.

Actions
Copy link
 #2

Updated by Tomáš Doischer about 4 years ago

  • Status changed from In Progress to Needs feedback
  • % Done changed from 50 to 80

Tests added, ready for code-review.

Actions
Copy link
 #3

Updated by Tomáš Doischer about 4 years ago

We decided to make this a little bit more granular, you can now specify which attributes are supposed to be case-insensitive.

https://git.bcvsolutions.eu/modules/reg/-/commit/d13108a29a814433b1058601504178168a997305

Documentation updated.

Actions
Copy link
 #4

Updated by Roman Kučera about 4 years ago

Thx, it works correctly.
I did feedback. LGTM
Maybe DefaultRegConfiguration::324 - 328 could be replaced by anyMatch :) but that's just a suggestion

Actions
Copy link
 #5

Updated by Ondřej Kopr about 4 years ago

During release module was issue with these dependencies:

Add mnaven processor plugin

[ERROR] Failed to execute goal org.bsc.maven:maven-processor-plugin:4.0-rc1:process (process) on project idm-reg: Execution process of goal org.bsc.maven:maven-processor-plugin:4.0-rc1:process failed: Unable to load the mojo 'process' in the plugin 'org.bsc.maven:maven-processor-plugin:4.0-rc1' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: org/bsc/maven/plugin/processor/MainAnnotationProcessorMojo has been compiled by a more recent version of the Java Runtime (class file version 53.0), this version of the Java Runtime only recognizes class file versions up to 52.0

But this will be little harder :(

[ERROR] Failed to execute goal io.github.swagger2markup:swagger2markup-maven-plugin:1.3.1:convertSwagger2markup (default) on project idm-reg: Execution default of goal io.github.swagger2markup:swagger2markup-maven-plugin:1.3.1:convertSwagger2markup failed: Plugin io.github.swagger2markup:swagger2markup-maven-plugin:1.3.1 or one of its dependencies could not be resolved: The following artifacts could not be resolved: nl.jworks.markdown_to_asciidoc:markdown_to_asciidoc:jar:1.0, ch.netzwerg:paleo-core:jar:0.10.2: Could not transfer artifact nl.jworks.markdown_to_asciidoc:markdown_to_asciidoc:jar:1.0 from/to jcenter-snapshots (http://oss.jfrog.org/artifactory/oss-snapshot-local/): Transfer failed for http://oss.jfrog.org/artifactory/oss-snapshot-local/nl/jworks/markdown_to_asciidoc/markdown_to_asciidoc/1.0/markdown_to_asciidoc-1.0.jar 409 -> [Help 1]

Repository oss-snapshot-local rejected dependency:

{
  "errors" : [ {
    "status" : 409,
    "message" : "The repository 'oss-snapshot-local' rejected the resolution of an artifact 'oss-snapshot-local:nl/jworks/markdown_to_asciidoc/markdown_to_asciidoc/1.0/markdown_to_asciidoc-1.0.jar' due to conflict in the snapshot release handling policy." 
  } ]
}

Actions
Copy link
 #7

Updated by Ondřej Kopr about 4 years ago

  • Status changed from Needs feedback to Closed
  • % Done changed from 80 to 100

Version 2.3.2 was released. Thank you Radek for help with solving dependencies.

Actions
Copy link

Also available in: Atom PDF