Project

General

Profile

Actions

Feature #2491

closed

Script usage agenda doesn't search in attribute mapping

Added by Ondřej Kopr over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
High
Assignee:
Tomáš Doischer
Category:
Scripts
Target version:
Start date:
09/16/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Please improve the agenda Script usage. The agenda now search only in another scripts. But script is also used in attribute mapping. Please allow searching in the attribute mapping (somehow :)).

Actions #1

Updated by Radek Tomiška over 3 years ago

This task will be more complicated - basically any text column (+custom module) can contain script. Without some entity attribute annotation (~registrable), this task cannot be solved i think.

Actions #2

Updated by Ondřej Kopr over 3 years ago

Radek Tomiška wrote:

This task will be more complicated - basically any text column (+custom module) can contain script. Without some entity attribute annotation (~registrable), this task cannot be solved i think.

This is true :( for debugging and analyze some issues will enought search only in attribute mapping. So if we will added new table or insert record in the current Usage table, only for attribute mapping it will be enough for this moment.

But this solutions isn't perfect and nice.

Actions #3

Updated by Radek Tomiška over 3 years ago

I almost forgot - workflow can use scripts too + from java code => I'm able to call script dynamically from every place.

But simple solution above will help I hope so.

Actions #4

Updated by Alena Peterová over 3 years ago

You are right, but the simple solution will still help a lot. The question always is: "Is this script used? Where?". Java code, workflows and scripts are saved in Git repository, we can run "grep" and find if they contain the script (its code name). But we can't simply "grep" the IdM database for usage of transformation scripts.

Actions #5

Updated by Radek Tomiška over 3 years ago

ok, I'm just afraid, this information will not lead to admin delete some script "which is not used" :)

Implementation note for simple solution: new tab in script detail can be registered in acc module (=> mapping is not in core).

Actions #6

Updated by Tomáš Doischer almost 2 years ago

  • Assignee changed from Ondřej Kopr to Tomáš Doischer
  • Priority changed from Low to High
  • Target version set to 13.0.0

This is absolutely needed on projects. We have to add this.

Actions #7

Updated by Tomáš Doischer over 1 year ago

  • Sprint set to Sprint 12.3-3 (srp 31 - zář 14)
Actions #8

Updated by Tomáš Doischer over 1 year ago

  • Status changed from New to In Progress
Actions #9

Updated by Tomáš Doischer over 1 year ago

I cannot use the basic script filter since this is an acc module feature. I will create a custom controller and service in the acc module and put a new tab in the script detail.

Actions #10

Updated by Tomáš Doischer over 1 year ago

  • Sprint changed from Sprint 12.3-3 (srp 31 - zář 14) to Sprint 12.3-4 (zář 14 - zář 28)
Actions #11

Updated by Tomáš Doischer over 1 year ago

  • % Done changed from 0 to 70

Implemented, tests are running now.

PR: https://github.com/bcvsolutions/CzechIdMng/pull/266

Actions #12

Updated by Tomáš Doischer over 1 year ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Tomáš Doischer to Roman Kučera
  • % Done changed from 70 to 80

The tests passed, can you please give me feedback?

Actions #13

Updated by Roman Kučera over 1 year ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Roman Kučera to Tomáš Doischer

LGTM, thx. It's working nicely.
There is only one small thing, after that I will marge it.

Actions #14

Updated by Tomáš Doischer over 1 year ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Tomáš Doischer to Roman Kučera
Actions #15

Updated by Roman Kučera over 1 year ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Roman Kučera to Tomáš Doischer
  • % Done changed from 80 to 100

LGTM, merged

Actions #16

Updated by Tomáš Doischer about 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF