Priority task #2462
closed
Advanced workflows for role criticality approval: do not remove disabled users from approvers
100%
Description
Advanced workflows for role criticality approval remove user from set of approvers if the identity is disabled. But in case of the identity is disabled manualy and has any valid contract it shouldn't be removed from the set of approvers.
It's caused by candidates.removeIf(IdmIdentityDto::isDisabled); in DefaultExtrasWfApprvingService https://github.com/bcvsolutions/czechidm-extras/blob/185ff2a876315137cd43b309ca7b2340c91ea1b5/Realization/backend/idm-extras/src/main/java/eu/bcvsolutions/idm/extras/service/impl/DefaultExtrasWfApprovingService.java#L178
E.g. product workflow approve-role-by-guarantee doesn't remove manualy disabled users form the set of approvers.
Related issues
Updated by Vladimír Kotýnek over 4 years ago
- Priority changed from Normal to Urgent
Updated by Petr Michal over 4 years ago
- Status changed from New to Needs feedback
- Assignee changed from Petr Michal to Peter Štrunc
- % Done changed from 0 to 70
Implemented in branch: https://github.com/bcvsolutions/czechidm-extras/tree/michalp/%232462-select-approver-valid-states
Documentation added to: https://wiki.czechidm.com/tutorial/adm/modules_extras_wf
Updated by Peter Štrunc over 4 years ago
- Copied to Priority task #2469: Advanced workflows for role criticality approval: do not remove disabled users from approvers added
Updated by Peter Štrunc over 4 years ago
- Status changed from Needs feedback to Closed
- % Done changed from 70 to 100
Thanks for this feature. It has been merged to develop.