Project

General

Profile

Actions
Copy link

Task #2440

closed

Copy fe-sources to the JAR

Added by Alena Peterová over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Marek Klement
Target version:
3.0.1
Start date:
08/18/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

The frontend sources aren't copied to the built JAR now during copy-fe-sources, because the path to their directory is one level higher than it's defined in the copy-fe-resources execution:

                                <resource>
                                    <directory>../frontend</directory>
                                    <filtering>false</filtering>
                                    <excludes>
                                        <exclude>**/.*</exclude>
                                    </excludes>
                                </resource>

FE sources should be included, so we can build the projects that use the Registration module with IdmTool.

Files

Download all files
bug_or_feature.png (36 KB) bug_or_feature.png Ondřej Kopr, 09/01/2020 02:11 PM
sorry.jpg (44.8 KB) sorry.jpg Marek Klement, 09/02/2020 06:36 AM
Actions
Copy link
 #1

Updated by Ondřej Kopr over 3 years ago

  • Assignee set to Marek Klement
Actions
Copy link
 #2

Updated by Marek Klement over 3 years ago

  • Target version set to 3.0.1
Actions
Copy link
 #3

Updated by Marek Klement over 3 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Marek Klement to Ondřej Kopr
  • % Done changed from 0 to 80

Build added and adjusted according to extras module. Should be good. Can you make review please @kopro

Actions
Copy link
 #4

Updated by Ondřej Kopr over 3 years ago

I didn't find your changes, please give me some hint where I find these changes :)

Actions
Copy link
 #5

Updated by Ondřej Kopr over 3 years ago

  • Assignee changed from Ondřej Kopr to Marek Klement
Actions
Copy link
 #6

Updated by Marek Klement over 3 years ago

Sorry, here is a commit: https://git.bcvsolutions.eu/modules/reg/commit/fb7b208efd5a624a794e26d8e002edb41bd880d2

I also adjusted order of some items in pom - should not affect anything

Actions
Copy link
 #7

Updated by Marek Klement over 3 years ago

  • Assignee changed from Marek Klement to Ondřej Kopr
Actions
Copy link
 #8

Updated by Ondřej Kopr over 3 years ago

You remove all author? Why you do this? I know that you want own the registration module, but this isn't correct way :D

And also change output folder of asciidoc to extras isn't also good. I think that you just will add 7 rows from Alča description.

Actions
Copy link
 #9

Updated by Marek Klement over 3 years ago

  • File sorry.jpg sorry.jpg added
  • Status changed from In Progress to Needs feedback
  • Assignee changed from Marek Klement to Ondřej Kopr
Actions
Copy link
 #10

Updated by Ondřej Kopr over 3 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Ondřej Kopr to Marek Klement
  • % Done changed from 80 to 100

Together we updated pom.xml with these lines:

<resources>
    <resource>
        <filtering>false</filtering>
        <directory>target/idm</directory>
    </resource>
</resources>
Actions
Copy link
 #11

Updated by Marek Klement over 3 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF