Project

General

Profile

Actions
Copy link

Task #2376

closed

Add skip of approval task for requester in role approval wf

Added by Petr Michal almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Petr Michal
Target version:
2.5.0
Start date:
07/08/2020
Due date:
% Done:

100%

Estimated time:
Owner:
Actions
Copy link
 #2

Updated by Petr Michal almost 4 years ago

  • Status changed from In Progress to Needs feedback
  • % Done changed from 0 to 80
Implemented in branch michalp/add-skip-to-approval-wf
New method to check if logged user is in task candidates + test
Method used in all extras approval workflows
  • extras-approve-role-by-contract-manager
  • extras-approve-role-by-manager-and-guarantee
  • extras-approve-role-by-manager-script-guarantee
Actions
Copy link
 #3

Updated by Alena Peterová almost 4 years ago

I made code review and tested the process, it works fine.
The algorithm for skipping the tasks is the same as in the product approval workflows (https://wiki.czechidm.com/devel/documentation/requests/adm/approval-process#automatic_skipping_of_approval_processes).

Just one thing - the fix is set to version 2.5.0, but now the branch still has POM with the already released version 2.4.0.
The same version (2.5.0) should be probably set for the fix #2351, which is also in develop and not in master branch.

Actions
Copy link
 #4

Updated by Peter Štrunc over 3 years ago

  • Status changed from Needs feedback to Closed
  • % Done changed from 80 to 100
Actions
Copy link

Also available in: Atom PDF