Feature #2371
closed
Show all approvers of task
100%
Description
When an approval task has more approvers, just the first few is displayed in the detail and in the table with list of tasks. Instead of showing the rest of them, there are dots: "..."
As a user I have no way to find all the approvers who can solve the task.
I'd like to allow the user to load the rest of the approvers e.g. via clicking on the "..."
Updated by Radek Tomiška over 4 years ago
- Assignee changed from Radek Tomiška to Vít Švanda
Updated by Vít Švanda over 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 50 to 90
Implemented.
You can see all approvers via clicking on the "...". Table of identities is limmited on first 100 approvers now. Limitation is necessary because IDs are send in GET request and these has limitation on 8kB. I tested this on Chrome, Firefox, IE, Edge all supports 8kB.
Beware on some more strict limitation for size of GET request on Apache (we need 4kB now)!
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/6bc7b546867eab4fdfe07e62c34bc1601c3f0670
Updated by Radek Tomiška over 4 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Vít Švanda
I did test and review, it works, thx!
Minor review notes:
- Filter layout in modal window is broken by default. Maybe large modal can be used?
- Modal dialog header could be dynamic (props) - e.g. 'Approvers' in this case.
- IdentitiesInfo folder in content is redundant (~ it's content now, not component). It's the first folder with the first upper letter :)
- [] bracket missing for arguments in localization messages (or highlight class can be used as for bulk actions).
Updated by Vít Švanda over 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Vít Švanda to Radek Tomiška
- Using large modal is good hint.
- I don't aggree the IdentitiesInfo is no longer component. The folder was here only for keep the README and component together (so the folder has different puropouse here). But I understand you have a emotion from using big char here :-), so I remove folder and README.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/4c021175540322cd382ef18411423b01020b51ab
Updated by Radek Tomiška over 4 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Vít Švanda
Thx, i did review again, i like it :)
One new note:
- new prop 'headerKey' can be renamed to 'header' (e.g. Table, Tree component) and localized text can be given. Benefit - the caller can add additional localization parameters if needed (e.g. escape).
Updated by Vít Švanda over 4 years ago
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100