Project

General

Profile

Actions
Copy link

Task #211

closed

Audit detail for other entities

Added by Ondřej Kopr over 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Audit
Target version:
Citrine (7.3.0)
Start date:
11/23/2016
Due date:
% Done:

100%

Estimated time:
Owner:

Description

  • Found good solution for show audit detail. One for all?
  • Cutt of envers?

Files

audit.jpg (156 KB) audit.jpg Ondřej Kopr, 12/20/2016 11:59 AM
Actions
Copy link
 #1

Updated by Radek Tomiška over 7 years ago

  • Target version changed from Beryl to Citrine (7.3.0)
Actions
Copy link
 #2

Updated by Ondřej Kopr over 7 years ago

Actions
Copy link
 #3

Updated by Ondřej Kopr over 7 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #4

Updated by Vít Švanda over 7 years ago

  • Status changed from In Progress to New
Actions
Copy link
 #5

Updated by Ondřej Kopr over 7 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #6

Updated by Ondřej Kopr over 7 years ago

  • % Done changed from 0 to 80
  • Add two DTOs class for audit,
  • implement endpoint and service for diff between two version of entity,
  • add default idm audit detail with comparsion of two details,
  • add test for diff.

In task #258 will be changed value for select box with revision chooser.

Please check my design and report me UX problem, also do code review. Thank you.

Actions
Copy link
 #7

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
Actions
Copy link
 #8

Updated by Ondřej Kopr over 7 years ago

  • Assignee changed from Radek Tomiška to Vít Švanda
Actions
Copy link
 #9

Updated by Ondřej Kopr over 7 years ago

  • Assignee changed from Vít Švanda to Ondřej Kopr
  • % Done changed from 80 to 70
Actions
Copy link
 #10

Updated by Ondřej Kopr over 7 years ago

  • Assignee changed from Ondřej Kopr to Vít Švanda
  • % Done changed from 70 to 80

Found problem when compare two diffrent revision (role X identity). This problem was fixed.

Actions
Copy link
 #11

Updated by Ondřej Kopr over 7 years ago

  • % Done changed from 80 to 90
Actions
Copy link
 #12

Updated by Ondřej Kopr over 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Ondřej Kopr
  • % Done changed from 90 to 80
Actions
Copy link
 #13

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Vít Švanda
  • % Done changed from 80 to 90

Sulution your feedback:

  • redesign audit detail,
  • fix reload audit detail info component,
  • fix reload no previous version,
  • add filter with entity id and column with entity id.

Found minor bug with component DateTimePicker value reset, after choose revision with no previous version has this component still value from previous.

Please continue with feedback, thank you.

Actions
Copy link
 #14

Updated by Vít Švanda about 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Ondřej Kopr

I did review.
- Audit detail and table looks fine.
- Frontend code of audit detail looks nicely.

I found some minor problems.
- Audit detail - during revision change is not used showLoading. As user I am little confused.
- When I go to audit detail for SysSystemFormValue, then I see only one column Owner. But I want see value. You have to search audited fields recursively (than you find AbstractEntity).
Actions
Copy link
 #15

Updated by Ondřej Kopr about 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Vít Švanda

I repaired showloading on audit detail, there is two components auditDetailInfo and auditDetailInfoTable, bouth have showloading for now.

Please close this ticket. :)

Actions
Copy link
 #16

Updated by Ondřej Kopr about 7 years ago

ps: add others column like modifier and etc. will be added in task #294

Actions
Copy link
 #17

Updated by Vít Švanda about 7 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Ondřej Kopr

Everything looks greate.

Actions
Copy link
 #18

Updated by Ondřej Kopr about 7 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 90 to 100
Actions
Copy link

Also available in: Atom PDF