Actions
Task #200
closedEAV form - form definition agenda
Start date:
11/22/2016
Due date:
% Done:
100%
Estimated time:
16.00 h
Owner:
Description
Features:
- form definition list
- form definiton detail
- add / edit / delete definition
- add / edit / delete form attribute in form definition
Updated by Radek Tomiška about 7 years ago
- Assignee changed from Radek Tomiška to Ondřej Kopr
Updated by Ondřej Kopr about 7 years ago
- % Done changed from 0 to 90
Agenda for form definitions and attributes was implemented.
Please Radek do code review, thank you :)
Updated by Ondřej Kopr about 7 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
Updated by Radek Tomiška about 7 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 80
I did test and review, basic functionality is ok, i found some issues and some code improvements:
- focus is missing on every detail form
- add system checkbox to form definition table and to both details (with the helpBlock as on notification template)
- unify system attribute name through application (notification templates, eav ...)
- remove back link button bellow attributes table
- label for definition type is missing, when new form definition is created
- you could you new getNavigationKey method instead selectNavigationItems in componentDidMount (see AbstractContent jsdoc)
- synchronize security permission for eav in FE - BE (change app_admin permission to concrete eav permission)
- demo form definitions and attributes shouldn't be checked as system. Change system default value to false and fill system flag, when is needed.
- i can edit system entities through rest api (add validation result code ex for all system entities please - notification ...)
- add localization to all error codes (e.g. removing used attribute ..)
- rich text area doesn't work in eav form - i overlooked this issue, when rich text area was changed.
- please add note about agenda to https://proj.bcvsolutions.eu/ngidm/doku.php?id=navrh:eav
Updated by Ondřej Kopr about 7 years ago
- % Done changed from 80 to 90
- add focus to name / displayName,
- add checkbox (formDefinition and formAttribute) + helpBlock,
- create new interface with some information and example of use (UnmodifiableEntity)
- back link button was removed,
- label for definition types was added,
- change selectNavigationItems to getNavigationKey,
- change BE application permission (add method post, put, patch, delete),
- change default value to false, from now we must explicit set this flag,
- add explicit check to all values tht can be modified (into controller, from service is this change allowed),
- add new and old error message to localization,
- thank you for your help with found error with EAV and rich text area, now everything working,
- add some information about definitions and attributes to documentation.
Please check this feedback issues.
Updated by Radek Tomiška about 7 years ago
I did test and review, thx for good job! I found some minor issues:
- use isNew method, when checking entity is new - id could be sent even for new entity
- form definition name is disabled even for modificable definitions
Its all, after this minor changes, you could close this ticktet .)
Updated by Ondřej Kopr about 7 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
Actions