Task #1858
closed
Move connector to github, configure jenkins, sonar, nexus
100%
Description
Move connector from gitlab to github.
Configure automatic build on jenkins + sonar check
Configure automatic deploy to nexus
Updated by Petr Fišer almost 5 years ago
- Status changed from New to In Progress
- Assignee set to Petr Fišer
Updated by Petr Fišer almost 5 years ago
- Assignee changed from Petr Fišer to Roman Kučera
Updated by Roman Kučera over 4 years ago
- % Done changed from 0 to 20
I changed the groupId and artifactId of our forked AD bundle connector to new one.
Implementation in branch https://git.bcvsolutions.eu/modules/adbundle-connector/commits/1858-change-groupid-artifactid
I tested it briefly via IdM on getting user from end system.
Next step is change the dependency in WinRM+AD connector to this new AD. And release both connectors
In WinRM+AD connector the change is here https://git.bcvsolutions.eu/modules/winrm-ad-connector/commits/1858-dependency-for-our-ad
Updated by Roman Kučera over 4 years ago
- % Done changed from 20 to 30
I added licence information into new files in WinRM+AD connector. Added copyright information into files which we changed.
Added CHANGELOG.md with changes which we made in this WinRM+AD connector which is based on CMD connector from connid.
All things for WinRM+AD connector are implemented in https://git.bcvsolutions.eu/modules/winrm-ad-connector/commits/1858-dependency-for-our-ad
Updated by Roman Kučera over 4 years ago
- Assignee changed from Roman Kučera to Petr Fišer
- % Done changed from 30 to 50
I checked our AD fork and there is already CHANGELOG.md file, so I only added information about changes in groupId for artifact.
To AD connector I added copyright mentions in files where we made changes.
@fiserp Could you please check out the changes which I made in both connectors and tell me if there is something else which we need to fix before publishing to Github?
WinRM+AD - https://git.bcvsolutions.eu/modules/winrm-ad-connector/commits/1858-dependency-for-our-ad
AD - https://git.bcvsolutions.eu/modules/adbundle-connector/commits/1858-change-groupid-artifactid
Updated by Petr Fišer over 4 years ago
I checked both repos, seems OK to me.
What we should do next:- AD bundle connector
prepare branches for release, merge everything into master(gitlab says this is already merged)- create github repo and move the master therein
- create new develop out of master
- create github release
- create wiki page if needed
- update IdM product dependency to work with new artifact, also update changelog - this is possibly a breaking change
- set build / upload to nexus of the new artifact
- winrm connector
- merge all unmerged branches to develop and develop to master (currently only 1858-dependency-for-our-ad)
- other steps the same as above
Updated by Roman Kučera over 4 years ago
Petr Fišer wrote:
I checked both repos, seems OK to me.
What we should do next:
- AD bundle connector
prepare branches for release, merge everything into master(gitlab says this is already merged)
Branch in AD bundle connector 1858-change-groupid-artifactid is not already merged.
Updated by Roman Kučera over 4 years ago
WinRM + AD connector. All branches merged and deleted. Released version 1.0.4, published to nexus.
AD bundle connector - other merged branches deleted. Prepared merge request into master.
Updated by Petr Fišer over 4 years ago
Publicly released both connectors on github. Internal repos are deprecated from now on.
We still need to do some wiki stuff and readme stuff; just to polish things a bit.
@kucerar I gave you admin rights on those two github repos. Also, there is a security alert on winrm-ad connector about jackson-databind. Could you please look at it?
Updated by Petr Fišer over 4 years ago
Configured jenkins. Sonar should pick up automatically after first successful Jenkins build.
There were some issues with AD test I worked around (disabled original tirasa integration tests). But this is also located in the winrm-ad-connector... maybe make sure those will not run. I left it as it was, because winrm-ad-connector does not have any test profile and such. Also not sure about running the CMD connector tests.
After we get the build to work on Jenkins (there are still mycila licensing problems reported), maybe we should do auto deploy to nexus?
Updated by Petr Fišer over 4 years ago
- Assignee changed from Petr Fišer to Roman Kubica
- % Done changed from 50 to 90
I configured Jenkins and also corrected test profiles in pom.xml files in both repos. Both project building fine in CI from develop branch. Jenkins pushes all thing automatically to Sonar.
Also added distributionManagement configs to POMs so all should be good now.
@kucerar Could you do a brief review please? All changes in both repos are currently in the develop and I expect them to release with the next official release. It is not a problem if they stay in develop for a while because all of them are just developer convenience / code quality things.
Updated by Petr Fišer over 4 years ago
- Assignee changed from Roman Kubica to Roman Kučera
Updated by Petr Fišer over 4 years ago
Jenkins now also pushes to Nexus. We have to start using -SNAPSHOT versions to avoid confusion.
Updated by Petr Fišer over 4 years ago
We started using snapshots - I configured the missing info in pom.xml.
Nexus refuses when Jenkins tries to upload packages, I created #2262 specifically for this.
I think we can close this once Roman finishes review. :)
Updated by Roman Kučera over 4 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
Thx for this. I check your commits and it looks good to me. Jenkins build is working to.
I am closing this ticket now. The rest will be solved in #2262 as Petr wrote.