Actions
Task #1791
closed
Improve test coverage for DefaultSysProvisioningBreakConfigService
Status:
Rejected
Priority:
Normal
Assignee:
Vít Švanda
Category:
Test
Target version:
-
Start date:
08/12/2019
Due date:
% Done:
80%
Estimated time:
4.00 h
Owner:
Description
Wiki: https://wiki.czechidm.com/tutorial/adm/provisioning#provisioning_brake
Sonar with actual coverage: https://sonar.bcvsolutions.eu/dashboard?id=eu.bcvsolutions.idm%3Aidm-acc%3Asrc%2Fmain%2Fjava%2Feu%2Fbcvsolutions%2Fidm%2Facc%2Fservice%2Fimpl%2FDefaultSysProvisioningBreakConfigService.java
The goal is not only to improve coverage tests, but also to get acquainted with this agenda.
Updated by Artem Kolychev over 4 years ago
- Status changed from New to In Progress
Updated by Vít Švanda over 4 years ago
- Target version changed from Rhyolite (9.7.3) to Rhyolite (9.7.5)
Updated by Artem Kolychev over 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Artem Kolychev to Vít Švanda
artem/#1791-test-break_config_service
learned how work provisioning break
created test
fixed bug with nullabel var
Updated by Vít Švanda over 4 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Vít Švanda to Artem Kolychev
- Target version changed from Rhyolite (9.7.5) to 10.0.0
- % Done changed from 0 to 80
I did code review:
- We don't use a mask in package definition "org.springframework.data.domain.*". Please revet it.
- I was not able check your changes in the test class "ProvisioningBreakProcessorTest", because you reformated all rows. So all original rows were removed. You must not reformat the foreign code! Please repair it. https://github.com/bcvsolutions/CzechIdMng/compare/develop...artem/%231791-test-break_config_service?expand=1#diff-d7554b694599930e3b3face1a32d8ef6
Updated by Artem Kolychev over 4 years ago
https://github.com/bcvsolutions/CzechIdMng/pull/63/files
rolback format + extended test
Updated by Artem Kolychev over 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Artem Kolychev to Vít Švanda
Updated by Vít Švanda over 4 years ago
- Status changed from Needs feedback to Rejected
Actions