Task #1720
closed
Recertification of assigned roles
100%
Description
- Approving by identity-contract
- Approvers are managers of identity
- Bulk action for start recertification (filter under identity table) with specific permission.
- Request has relation only on identity-contract.
- After approve will be logged structured snapshot of all roles.
Related issues
Updated by Radek Tomiška over 5 years ago
- Status changed from New to In Progress
Updated by Radek Tomiška over 5 years ago
- Category set to Roles
- % Done changed from 0 to 60
I created new agendas for role recertification with main features implemented from description above.
Remain:
- Rerun recerticication saved as template (requires save filled bulk action setting),
- prefill recertification name by selected roles ('Recertification' is used for now),
- prepared filters for get recertification by approvers (by contract amd by role guarantee), but evaluator have to be implemented,
- tests,
- documentation.
All in branch https://github.com/bcvsolutions/CzechIdMng/tree/recertification
Updated by Radek Tomiška over 5 years ago
- Related to Task #1758: LRT: run long running task again added
Updated by Radek Tomiška over 5 years ago
- Related to Task #1759: Run recertification action again added
Updated by Radek Tomiška over 5 years ago
- Category changed from Roles to Recertification
Updated by Radek Tomiška over 5 years ago
- Related to Task #1760: Assigned roles tab - move FE tabs to BE added
Updated by Radek Tomiška over 5 years ago
- Project changed from IdStory Identity Manager to Recertification (rec)
- Category deleted (
Recertification) - Target version changed from Rhyolite (9.7.0) to 1.0.0
- % Done changed from 60 to 80
Moved into standalone module. Will be released under 1.0.0 version.
Features requied for this module made in core:
- improve filters for find subordinates by contract manager
- add new eav persistent type ENUMERATION
Commit to review (product):
https://github.com/bcvsolutions/CzechIdMng/commit/07044e56cfddc09d85b3d1b1ea69952d6fc9d695
Updated by Radek Tomiška over 5 years ago
- Related to Task #1762: Report for recertification action added
Updated by Radek Tomiška over 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 80 to 90
I created module, sources are here:
https://git.bcvsolutions.eu/modules/recertification
Could you do a feedback, all needed features are implemented instead report (#a762).
I will add documentation and test in the meantime.
Updated by Radek Tomiška over 5 years ago
- Related to Task #1678: EAV form: support enumeration as face type added
Updated by Radek Tomiška over 5 years ago
I've added sorting for bulk actions by localized label alphabetically:
https://github.com/bcvsolutions/CzechIdMng/commit/f41f7246f39f0ada15cec711864b56a56477999f
And new tab to role detail with role recertification:
https://git.bcvsolutions.eu/modules/recertification/commit/93cdd220d5a8fe1d19f37bd81df23581911b2a95
And change default for recertificate role interval:
https://git.bcvsolutions.eu/modules/recertification/commit/049754700eb1d77181faf994330d10abe1ff82fa
All changes are related to feedback on friday.
Updated by Vít Švanda over 5 years ago
I reviewed a core part (testing will be within recertification module). Filtering subordinates and managers via contracts will be useful. Because I am constant, from some changes I have a strong feelings and make me sad ;-).
Updated by Radek Tomiška over 5 years ago
Documentation created:
https://wiki.czechidm.com/devel/documentation/modules_rec
Updated by Radek Tomiška over 5 years ago
Updated by Vít Švanda over 5 years ago
- File LRT-waiting.webm added
I tested REC module (code review will coming soon). Module is awesome and works prefectly.
I found only small issues:
- Button for add request doesn't work (candidate for hide ).
- If I start recertification only for users without contract, then bulk action (progress bar) stay waiting.
- If I choose NO in modal dialog for approving, then in the console occured exception (without inpact on anything).
- I propose that the nice lable of recertification should only show the type of recertification and the date till. Showing of individual requests (users) seems to me not very UX.
- Notifications is very economically, but works. I have only one issue. In others notifications we have subject of the email in the czech, but your subjects are in english (recRecertificationDueDateWarning, recNewRecertificationRequest).
- Typo: "contracted position".
Updated by Radek Tomiška over 5 years ago
Notes above fixed:
https://github.com/bcvsolutions/CzechIdMng/commit/71090678de72793d6ef7f1778c6602583b6861d4
https://git.bcvsolutions.eu/modules/recertification/commit/d96f1f3a76fac1712f6e34910857ec002eed363a
Just name of recertification action remains the same (i don't have any substitution).
Updated by Vít Švanda over 5 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 90 to 100
I completed the code review. Code is nice and great. Very nice coverage of a code (88, 5%) . Thanks for this module.
Updated by Radek Tomiška over 5 years ago
- Status changed from Resolved to Closed
Thx for feedback!
Module version 1.0.0 is released.
Artefacts can be found here: https://nexus.bcvsolutions.eu/#browse/browse:maven-releases:eu%2Fbcvsolutions%2Fidm%2Fidm-rec%2F1.0.0