Project

General

Profile

Actions
Copy link

Task #167

closed

Role Catalogue

Added by Ondřej Kopr over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Roles
Target version:
Beryl
Start date:
10/19/2016
Due date:
% Done:

100%

Estimated time:
Owner:

Description

  • Add new agenda - role catalogue (create, edit, remove)
  • Rest endpoint for roleCatalogue
  • To roleDetail add new select with roleCatalogue

Table idm_role_catalogue + audit table (name, parent, info)

Actions
Copy link
 #1

Updated by Ondřej Kopr over 7 years ago

Change current implementation
  • add roleCatalogue to RoleFilter
  • add roleCatalogue to entity Role
New class
  • Entity RoleCatalogue
  • Excerpt for role catalogue
  • Filter - RoleCatalogueFilter with parent
  • Controller for role catalogue
  • Repository for role catalogue
  • Service for role catalogue

Test via SoapUi

Actions
Copy link
 #2

Updated by Ondřej Kopr over 7 years ago

  • % Done changed from 0 to 30
Actions
Copy link
 #3

Updated by Ondřej Kopr over 7 years ago

  • % Done changed from 30 to 90

Solutions may be found on branch: https://github.com/bcvsolutions/CzechIdMng/tree/okopr/%23167-role-catalogue
Please do code review and report me result. Thank you.

Actions
Copy link
 #4

Updated by Ondřej Kopr over 7 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
Actions
Copy link
 #5

Updated by Radek Tomiška over 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 50
I've found some issues / improvments:
  • i've reparied some referential integrity issues in change script
  • i've added TREE_NODE_BAD_TYPE result code to BE. Please add localization codes TREE_NODE_BAD_TYPE, TREE_NODE_BAD_PARENT to FE
  • role catalogue permission could be removed - role catalogue will have the same permissions as role (catalogue is 'decorator" for roles - respectively will be used as "filter" to roles)
  • role catalogue could be shown on roles content (resp. table) - the same design and behaviour as tree node content without select box
  • role catalogue navigation should be moved to setting - in main navigation will be roles only as before
  • localization for catalogue should be changed - we have only one catalogue with items (folders)
  • testNode method could be renamed to validate in TreeNodeService
Actions
Copy link
 #6

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 50 to 90
  • role catalogue permission was deleted and replace ROLE permissions,
  • role catalogue navigation was moved to settings,
  • localization for role catalogue was changed,
  • method testNode in DefaultIdmTreeNodeService was renamed to validate,
  • error codes: TREE_NODE_BAD_TYPE and TREE_NODE_BAD_PARENT was added to cs localization,
  • tree with role catalogue was addded to role table.
Actions
Copy link
 #7

Updated by Radek Tomiška over 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr

It works and code looks nice. Merge this changes to master please.

Actions
Copy link
 #8

Updated by Ondřej Kopr over 7 years ago

Merged to master.

Actions
Copy link
 #9

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100
Actions
Copy link

Also available in: Atom PDF