Project

General

Profile

Actions
Copy link

Defect #1605

closed

Close attachment's input stream used in provisioning

Added by Radek Tomiška about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Provisioning
Target version:
Pyrite (9.5.2)
Start date:
04/11/2019
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

Close attachment's input stream used in provisioning of extended attribute of type 'ATTACHMENT'.

Actions
Copy link
 #1

Updated by Radek Tomiška about 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • Target version set to Pyrite (9.5.2)
  • % Done changed from 0 to 90

I checked all places with attachment manager usage and found one place with reading attachment without close underlying input stream in provisioning of eav attribute ('DefaultSysSystemAttributeMappingService').

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/223aaf43fd5ebed074461737b453d7b1764fa08b#diff-e9b23f45e402c4957700f2c7606b3b28

Could you do a feedback, please?

Note: For save and update attachment was stream closed directly in attachment manager. Reading the attachment requires to caller close the stream only.

Actions
Copy link
 #2

Updated by Vít Švanda about 5 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I reviewed this. Thanks for that. For the next time I won't be so trusting in the appache IOUtils.

Actions
Copy link
 #3

Updated by Vít Švanda about 5 years ago

  • Assignee changed from Radek Tomiška to Vít Švanda
Actions
Copy link
 #4

Updated by Radek Tomiška about 5 years ago

  • Assignee changed from Vít Švanda to Radek Tomiška
Actions
Copy link

Also available in: Atom PDF