Project

General

Profile

Actions
Copy link

Task #1231

closed

Add default .gitignore file to module skeleton (improve maven module archetype)

Added by Patrik Stloukal over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Target version:
1.0.8
Start date:
08/30/2018
Due date:
% Done:

100%

Estimated time:
Owner:

Description

I was creating new backend module using new archetype and I thought everything will be generated so I just looked into names of classes and forget about gitignore , so in terminal it showed me whole folder i did not notice the other files.
I was wondering if gitignore can be generated with content.

Actions
Copy link
 #1

Updated by Ondřej Kopr over 5 years ago

  • Category set to Archetype
  • Status changed from New to Needs feedback
  • Assignee changed from Ondřej Kopr to Patrik Stloukal
  • Target version set to Moonstone (9.1.0)
  • % Done changed from 0 to 90

I added default gitignore file for archetype resources.

Commit: https://github.com/bcvsolutions/idm-module-archetype/commit/6b016e246439a2991b7fa1073f07cd2979b67b39 (branch develop)

Please could you makea review? Thank you.

Actions
Copy link
 #2

Updated by Radek Tomiška over 5 years ago

  • Subject changed from Improve generating of modules to Add default .gitignore file to module skeleton (improve maven module archetype)
  • Status changed from Needs feedback to In Progress
  • Assignee changed from Patrik Stloukal to Ondřej Kopr
  • Target version changed from Moonstone (9.1.0) to Morganite (9.2.0)
Actions
Copy link
 #3

Updated by Ondřej Kopr over 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška

Thanks Radek for review, I fixed exclusion of gitignore file.

Commit: https://github.com/bcvsolutions/idm-module-archetype/commit/639f5bb648bcae6ce81108d949ad2cf4fe3cd5a6 (develop)

For review please rebuild project locally and then use:

mvn archetype:generate \
      -Pczechidm-public-repo \
      -DinteractiveMode=false \
      -DarchetypeGroupId=eu.bcvsolutions.idm \
      -DarchetypeArtifactId=idm-module-archetype \
      -DarchetypeVersion=1.0.2-SNAPSHOT \
      -DartifactId=idm-dojo \
      -DmoduleName=Dojo \
      -Dauthor='John Doe' \
      -Dversion=1.0.0-SNAPSHOT \
      -DczechIdMVersion=8.1.3

Please could you check gitignore file now? Thank you.

Actions
Copy link
 #4

Updated by Radek Tomiška over 5 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
Actions
Copy link
 #5

Updated by Radek Tomiška over 5 years ago

  • Target version deleted (Morganite (9.2.0))
Actions
Copy link
 #6

Updated by Ondřej Kopr over 5 years ago

  • Project changed from IdStory Identity Manager to Archetype
  • Category deleted (Archetype)
  • Status changed from In Progress to Closed
  • Target version set to 1.0.8
Actions
Copy link
 #7

Updated by Ondřej Kopr over 5 years ago

  • Status changed from Closed to In Progress
Actions
Copy link
 #8

Updated by Ondřej Kopr over 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Patrik Stloukal

I checked the beahvior with gitignore again and works correctly, please Patrik could you make a review of my changes? Thank you.

Actions
Copy link
 #9

Updated by Radek Tomiška almost 5 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Patrik Stloukal to Ondřej Kopr
  • % Done changed from 90 to 100

I did test and it works correctly, thx.

Actions
Copy link

Also available in: Atom PDF