Project

General

Profile

Actions

Defect #1084

closed

Role request should be canceled after contract is deleted

Added by Vít Švanda almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Vít Švanda
Category:
Roles
Target version:
Start date:
04/26/2018
Due date:
% Done:

90%

Estimated time:
Affected versions:
Owner:

Description

Role request should be canceled (in concept) state after contract is deleted. Probably is only removed relation to contract now (on delete of the contract). After this can not be that request run.


Files

Actions #1

Updated by Vít Švanda almost 6 years ago

Role request (concepts) canceling is already implemented. Problem is in the canceling connected WF processes (those are not cancel now).

Actions #2

Updated by Vít Švanda almost 6 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Vít Švanda to Ondřej Kopr
  • % Done changed from 0 to 90
  • I implemented cancel of the role concept on delete a identity-contract and a role.
  • I also created tests for that.
Actions #3

Updated by Vít Švanda almost 6 years ago

  • Assignee changed from Ondřej Kopr to Alena Peterová
Actions #4

Updated by Alena Peterová almost 6 years ago

I tested only deleting of contracts.
The approval task in the WF process is canceled correctly, but the whole "Request for roles" (the process with the name "Change of permissions for user 'xxx'") stays open (please see the screenshot). I think it should be Canceled as well (if there are no other open sub-processes). It is also visible as "In Progress" in the User -> Roles -> Requests for authorization change, which can confuse users.

Some suggestions about the texts:
  • the phrase "role concept" is confusing, because "Concept" is the state of the request for authorization change, which wasn't submitted yet. I think we shouldn't use the phrase "role concept", because the request is already submitted and the approval task created.
    • "Role concept use this WF, was deleted. This WF was deleted too." -> "This task/process was canceled, because the requested role or contract were deleted."
  • name of the workflow "Approval change of assignmented role 'xxx' for user 'xxxx'" -> "Approval of change in assignment of the role ..."
Actions #5

Updated by Alena Peterová almost 6 years ago

  • Assignee changed from Alena Peterová to Vít Švanda
Actions #6

Updated by Vít Švanda almost 6 years ago

I understand, but there is a scenario that would not be work.

The request may exist without any concepts. Likewise, an extreme case may cause a user to ask for a role (creates a concept), and ask the other role by description in the request (he does not know witch exactly want). If the whole request will be terminated after the first role will be deleted, then a user's secound request (note in request) could not be satisfied.

Perhaps this is an extreme case. I can add a quit request if the last concept is canceled, but I'm not sure with this.

Actions #7

Updated by Alena Peterová almost 6 years ago

Good point! I didn't think about this use-case, but it's definitely a valid situation (especially when we have "Helpdesk" or "Managers of users" approval rounds enabled, who can add additional roles to the request).

So could we continue with the parent WF process based on the node, which is active? My idea:
  • Helpdesk, User's manager, Managers of users approval round - cancel the role from the request, but do nothing else to the approval task (it stays open, can be accepted or rejected, additional roles can be added to other contracts)
  • Roles criticality subprocess - cancel the subprocess with the deleted contract/role. Continue with the parent process as if the subprocess was denied.
  • Security - cancel the role from the request, but do nothing else to the approval task

But I don't know how complex would the implementation be :(

Actions #8

Updated by Vít Švanda almost 6 years ago

You discovered big issue, where canceled subprocess does not triggered the parent process. This is big problem ... I spent many hours with search the solution ... but without success.I created new task for this #1115.

Actions #9

Updated by Vít Švanda almost 6 years ago

  • Status changed from Needs feedback to Resolved
Actions #10

Updated by Radek Tomiška almost 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF