Project

General

Profile

Actions

Task #1079

closed

Mixing the organization and the name of the position in one column

Added by Alena Peterová almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Contractual relationship
Target version:
Start date:
04/20/2018
Due date:
% Done:

100%

Estimated time:
0.50 h
Owner:

Description

Feedback from our customer.
Version: 7.8.5
Please see the screenshot.
User -> Contracted positions -> Positions. When the contract doesn't have organization, the name of the position is displayed in the column "Position". This is strange and it confuses the administrator, because the column normally displays the name of the organization. He would expect to have it empty, if there is no organization (or even "error", because in his case it's an error - missing organization).


Files

zobrazeni_pozice.jpg (304 KB) zobrazeni_pozice.jpg Alena Peterová, 04/20/2018 08:29 AM
role_assign_specify_contract.png (35.2 KB) role_assign_specify_contract.png Alena Peterová, 05/14/2018 11:00 AM
Actions #1

Updated by Radek Tomiška almost 6 years ago

  • Assignee changed from Ondřej Kopr to Alena Peterová

This behavior was designed this way. Position can be defined simply by string or by tree structure (it's not "error"). Tree structure has higher priority, when column content is rendered.

I don't see an other solution now. Do you have any other ideas?

Actions #2

Updated by Alena Peterová almost 6 years ago

For our use case, it would be great to have two separate columns - first for the position name, second for the organisation, where the position is situated. This second column would be empty, if no organisation was found.

I understand that the designed way works well, if your organization structure is the structure of work positions. Then the position name and the name of the organisation may be the same. But in our case it is the structure of departments, so the position name is like "Hlavní správce finančního systému" and the organisation is "Oddělení financí v Praze". We would like to see both these information.

Actions #3

Updated by Radek Tomiška almost 6 years ago

  • Assignee changed from Alena Peterová to Radek Tomiška
  • Estimated time set to 0.50 h

Ok, i understand. I thought string position name is a decorator (~fallback), if organization is not given. I will add new column into contract table. The side effect is, table width will be increased (350px).

Actions #4

Updated by Alena Peterová almost 6 years ago

Thank you. About the width: You could remove the column "Organisation structure type" from this table. There is usually only one structure. Even if there were more, we would usually understand from the organization name, what type it is. If not, we can see it in the position detail.

Actions #5

Updated by Radek Tomiška almost 6 years ago

ok, thx. Organization structure type was removed already in #1025 .)

Actions #6

Updated by Alena Peterová almost 6 years ago

Would you please add the name of the position also in the select box in the role requests? When the user has more contracts in the same organisation and I want to add a new role, I can't distinguish, which contract to select - please see the screenshot.

Something like "name of the organisation (name of the position)" would be sufficient.

Actions #7

Updated by Radek Tomiška almost 6 years ago

  • Category changed from Feedback to Contractual relationship
  • Status changed from New to Needs feedback
  • Assignee changed from Radek Tomiška to Alena Peterová
  • Target version set to Jade (8.1.0)
  • % Done changed from 0 to 90

I added new column with contact position name into contracts table and updated select box and info components on role request pages.
Redundant column - inactive - was removed, contract state is better.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/82f6fd9c0d34797c366735889cb75737a603d8a7#diff-4c16365f7dd7686e43703821759a8a93

Could you do a feedback please?

Actions #8

Updated by Alena Peterová almost 6 years ago

  • Assignee changed from Alena Peterová to Radek Tomiška

It works, thanks!
Now only remains to display the name of the position in the tasks, but that's another ticket - #1085.

Please check the displaying of the column "Authorizers". The guarantee which is set directly on the contract is not displayed here. Also when I made a role request for the role with criticality 1, the task wasn't created.

Actions #9

Updated by Radek Tomiška almost 6 years ago

  • Status changed from Needs feedback to Closed
  • % Done changed from 90 to 100

Thx for feedback!

I will solve "Authorizers" in #1078, I'm working on it currently.

For the role request for the role with criticality 1 - i cannot reproduce it - role is approved by "Authorizers" :) (admin as fallback). Create pls new ticket with some additional info, how to reproduce this issue.

Actions #10

Updated by Alena Peterová almost 6 years ago

Radek Tomiška wrote:

Thx for feedback!

I will solve "Authorizers" in #1078, I'm working on it currently.

For the role request for the role with criticality 1 - i cannot reproduce it - role is approved by "Authorizers" :) (admin as fallback). Create pls new ticket with some additional info, how to reproduce this issue.

Finally found why direct guarantee "didn't work". The identity of the guarantee didn't have any active contract. That's probably why it wasn't displayed and the task wasn't created. (Criticality 1 is really approved by manager - idm.sec.core.wf.role.approval.1=approve-role-by-manager). When I activated the contract of the guarantee, it started working.

So I will only add to #1078 the wish to make the inactive guarantee distinguished on the first sight, because it really confused me.

Actions

Also available in: Atom PDF