Project

General

Profile

Actions
Copy link

Task #106

closed

Configurable allowed origin

Added by Radek Tomiška over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Configuration
Target version:
Amethyst
Start date:
08/19/2016
Due date:
% Done:

100%

Estimated time:
3.00 h
Owner:

Description

Add support for dynamic allowed origin configuration through ConfigurationService. Changing allowed origin could be dangerously, but can be usefull for new evironment configuration and for preventing backend server restart, when frontend moves to another server url etc. When origin is wrong, then frontend can't work - allowed origin configuration through rest api will be still posible.

Actions
Copy link
 #1

Updated by Radek Tomiška over 7 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 0 to 90

I've implemented dynamic cors configuation, like description above says. I've created some unit tests too.

Pease do a test and code review.

Note: This functionallity could not be tested through gui ( FE could not communicate with BE, if origin is wrong) - e.g. use soapUI with origin request header instead.

Actions
Copy link
 #2

Updated by Ondřej Kopr over 7 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 90 to 100

Feedback:

Code review: Radek is good schnitzel, his code is readable and nicely formatted, but newline missing in Realization/backend/client/src/main/resources/application.properties - OK
Tests: successful - OK
Test in SoapUI: after consultation - OK

Actions
Copy link
 #3

Updated by Radek Tomiška over 7 years ago

  • Status changed from Resolved to Closed

Thank you :)

Actions
Copy link

Also available in: Atom PDF