Project

General

Profile

Actions
Copy link

Task #1049

closed

Change modifier for method getSmsNumber

Added by Ondřej Kopr over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Notification
Target version:
Jade (8.1.0)
Start date:
04/03/2018
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Please change modifier for method getSmsNumber in class AbstractSmsNotificationSender to public. This method is override in sms script. Thank you.

You are probably best man for changes in this class (you are autor :D)

Actions
Copy link
 #1

Updated by Radek Tomiška over 6 years ago

  • Status changed from New to Closed
  • Assignee changed from Peter Štrunc to Radek Tomiška
  • % Done changed from 0 to 100

I changed modifier for method getSmsNumber in class AbstractSmsNotificationSender to public.

Note: Design of sms sender should be changed - getSmsNumber method belongs to service layer (e.g. see IdmEmailLogService#getEmailAddress), benefit: interface, could be overriden without dependency into module 'core-impl'.

Actions
Copy link

Also available in: Atom PDF