Project

General

Profile

Actions
Copy link

Defect #1022

closed

Fix send newly generated password to identity

Added by Ondřej Kopr about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
High
Assignee:
Ondřej Kopr
Target version:
1.2.1
Start date:
03/12/2018
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

Newly generated password is send without correctly filled recipient, update the behavior

Actions
Copy link
 #1

Updated by Ondřej Kopr about 6 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90

I created new branch with hotfix 1.2.1 and fix the problem

Commit: https://git.bcvsolutions.eu/modules/password-reset/commit/8ea740d6823b63a14fe2171cd0cd72bf9399563c (branch: hotfix/1.2.1)

I also created new page with version: https://wiki.czechidm.com/devel/documentation/modules_pwd/versions

Actions
Copy link
 #2

Updated by Ondřej Kopr about 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška

I added module prefix for topics, this is missing from version 1.0. I added flyway script that fix problem with existing topics.

Commit: https://git.bcvsolutions.eu/modules/password-reset/commit/2c6805883cecb2a680d8a2b3dd80a506c85aad87 (branch: hotfix/1.2.1)

Please Radek could you made a review? Thank you, this is simple fix.

Actions
Copy link
 #3

Updated by Petr Michal about 6 years ago

  • Priority changed from Normal to High
Actions
Copy link
 #5

Updated by Radek Tomiška about 6 years ago

  • Assignee changed from Radek Tomiška to Peter Štrunc
Actions
Copy link
 #6

Updated by Peter Štrunc about 6 years ago

  • Assignee changed from Peter Štrunc to Ondřej Kopr

I did review. It looks great. I think implementation is ok. And it worked for me. Please create test, that tests this aspect.

Actions
Copy link
 #7

Updated by Peter Štrunc about 6 years ago

  • Status changed from Needs feedback to In Progress
Actions
Copy link
 #8

Updated by Ondřej Kopr about 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Peter Štrunc

I checked test classes and I already founded test for sending newly generated password. You mean that I must added new test for topic names? Behavior with topic is tested by core module, is this need restest by password reset module?

Actions
Copy link
 #9

Updated by Peter Štrunc about 6 years ago

Did the test fail before you fixed the bug? If yes, then it is ok, but i think that there is no test that verifies that the new password is in fact sent to correct recipient.

Actions
Copy link
 #10

Updated by Ondřej Kopr about 6 years ago

You have truth, I made only filtering by recipient, but I didn't check recipient in result, so I add new assert after I recived result. Thanks :)

Commit: https://git.bcvsolutions.eu/modules/password-reset/commit/4b8127a0f2bcb7be527ff36c365a3b5298d5cb5b

Thank you for hint and please you can continue with feedback thank you :)

Actions
Copy link
 #11

Updated by Peter Štrunc about 6 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Peter Štrunc to Ondřej Kopr

Test looks fine. You can close the ticket.

Actions
Copy link
 #12

Updated by Ondřej Kopr about 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

Thanks for feedback, I close this ticket.

Actions
Copy link
 #13

Updated by Ondřej Kopr about 6 years ago

  • Status changed from Resolved to Closed

hotfix branch 1.2.1 is available for release #1023

Actions
Copy link

Also available in: Atom PDF