IdStory Identity Manager

consultation with Ondra about usefulness of scripts,
work on scripts, translation, editing, testing

I selected and modified 8 scripts from projects, please check it out and write feedback.

commit: https://github.com/bcvsolutions/CzechIdMng/commit/2367e307e924ad176eb37a0518aad11d3ff5b916

I made feedback (in given commit you only remove some script):

• getBooleanAsString

• you compare some of type object and then return "1" or "0", what if this attribute will not be boolean?
• last line missing,

• getBooleanFromIntegerInString

• you return null when values isn't equals to "1" or "0" but in description isn't this behavior described,

• GetCataloguesForRole

• is another code than in other scripts,
• add null check for entity,
• there is probably better solution: use as parameter ID not whole entity,

• GetFormattedDate

• same problem with code as above,
• in description is write: "Converts Joda's DateTime to 'yyyy-MM-dd HH:mm:ss' string", but this isn't true,
• parameter "patern" isn't in description,
• add null check!,

• GetStringAsLocalDate

• same problem with code,
• in doc is write: "Converts String to Local Date as 'dd.MM.yyyy'." this isn't true,

• GetUserRoles

• same problem with code,
• add null check,
• there is probably better solution: use as parameter ID not whole entity,
• you find only valid roles, please update name, code and description for this script,
• your return only distinct names add this behavior to description,

• GetIdentityAccAccount

• same problem with code,
• add null check,
• in doc is writes: "Returns AccAccount for provided identity and system." but this isn't true,
• you return false when you didn't find account, describe this behavior to documentation and description,
• name and code doesn't correspond with behavior, you return if is account in protection,

• printValue

• unless allowed class java.lang.System and org.apache.tomcat.util.log.SystemLogHandler,
• do you checked the script? This isn't works,
• org.slf4j.LoggerFactory.getLogger("Print Value script") and log.debug doesn't works :(, you must set something like eu.bcvsolutions..., you may check logback,

• "jackass defiant" (blbu vzdorné),
• their documentation must be awesome,
• inner documentation (comments) must be also awesome,
• behavior must be clear and described,
• this is javadoc for utils method in java: https://docs.oracle.com/javase/8/docs/api/java/util/Arrays.html#binarySearch-int:A-int-int-int-

In some project will people use this scripts as default pattern for project specific scripts. Is possible, that this only code that administrators see (not developers), so code must be easy to understand. Add a piece of heart to creating these scripts.

Check my feedback and then return this task back to me.