Project

General

Profile

Actions

Feature #915

closed

Add entity state agenda

Added by Ondřej Kopr about 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Artem Kolychev
Category:
Event
Target version:
Start date:
01/17/2018
Due date:
% Done:

100%

Estimated time:
8.00 h
Owner:

Description

Add new agenda for show entity states (show entity state/dirty state/concep etc.).
Agenda will be available under entity events agenda in audit menu.
Add bulk action for delete entity states (~clear dirty states).
Agenda will be (is) secured under 'app_admin' (will be improved in #1367 later).
FE table EntityStateTable will be reused - it was created before.

USE CASE:
  1. When is some entity in dirty state it's not any information about this state, also when is recalculated i have no information about it,
  2. in automatic roles is implement concept state and this state is changed after create, update or delete some rule. When I recalculate automatic role is this state still in concept and it will be changed after recalculation ends, for administrator's is this very confusing

Related issues

Related to IdStory Identity Manager - Task #468: Account management is synchronous with Role add operationClosedRadek Tomiška05/31/2017

Actions
Related to IdStory Identity Manager - Task #1367: Entity event queue - add base permissionsClosedRadek Tomiška11/08/2018

Actions
Related to IdStory Identity Manager - Task #1827: Entity state agenda: add result code column and filter by result state and code.ClosedArtem Kolychev09/02/2019

Actions
Related to IdStory Identity Manager - Task #1828: Entity state and entity event agenda - add available entity type select box.ClosedRadek Tomiška09/02/2019

Actions
Actions #1

Updated by Ondřej Kopr about 6 years ago

  • Subject changed from Add some operation state for entities to Add 'operation state' for entities
Actions #2

Updated by Radek Tomiška about 6 years ago

  • Assignee changed from Ondřej Kopr to Radek Tomiška
Actions #3

Updated by Radek Tomiška about 6 years ago

  • Related to Task #468: Account management is synchronous with Role add operation added
Actions #4

Updated by Radek Tomiška about 6 years ago

  • Description updated (diff)
  • Category set to Event
Actions #5

Updated by Radek Tomiška almost 6 years ago

In ticket #468 entity state table was added. Now is needed to create component on FE - show entity state.

Actions #6

Updated by Radek Tomiška almost 6 years ago

  • Related to Feature #1133: The state of an virtual account added
Actions #7

Updated by Radek Tomiška over 4 years ago

  • Subject changed from Add 'operation state' for entities to Add entity state agenda
  • Description updated (diff)
  • Assignee changed from Radek Tomiška to Artem Kolychev
  • Target version set to Rhyolite (9.7.3)
Actions #8

Updated by Radek Tomiška over 4 years ago

  • Description updated (diff)
Actions #9

Updated by Artem Kolychev over 4 years ago

  • Status changed from New to In Progress
Actions #10

Updated by Radek Tomiška over 4 years ago

  • Related to deleted (Feature #1133: The state of an virtual account)
Actions #11

Updated by Artem Kolychev over 4 years ago

  • Estimated time set to 8.00 h
Actions #12

Updated by Artem Kolychev over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Artem Kolychev to Vít Švanda

artem/#915-entity-state-agenda
added entity state agenda with bulk delete action and test

Actions #13

Updated by Radek Tomiška over 4 years ago

  • Assignee changed from Vít Švanda to Radek Tomiška
Actions #14

Updated by Radek Tomiška over 4 years ago

  • Related to Task #1367: Entity event queue - add base permissions added
Actions #15

Updated by Radek Tomiška over 4 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Artem Kolychev
  • % Done changed from 0 to 80

I did test and code review, agenda works and code is ok, thx!
I found some issues:
- change order for new item in menu - schould be under events menu (see description).
- change url on FE to '/entity-states' (see '/entity-events' for inspiration).
- change new content name 'AuditEntityStateTable' to 'EntityStates' and move into 'event' folder (see 'EntityEvents' for inspiration).
- remove used wildcard import in java classes (see contributing notes).
- fix cs localization - contains en localization (content 'entityStates').
- change localization for bulk action 'Remove selected state' => 'Remove selected states'
- 'EntityStateDeleteBulkActionIntegrationTest' creates statesin class initialization as array list generalization - move creation of states into normal method (even warning is shown). See 'EntityEventDeleteBulkActionIntegrationTest' for inspiration.
- Property 'detail' used for 'EntityStateTable' doesn't exist - should be removed.
- Property 'uiKey' - use spinal-case (seee 'EntityEvents' for inspiration)

We need to add additional filters to this agenda (e.g find by result code ~ dirty state), but it will be solved in next ticket.
We need add detail (modal), but it will be solved in next ticket.

Actions #16

Updated by Vít Švanda over 4 years ago

  • Target version changed from Rhyolite (9.7.3) to Rhyolite (9.7.5)
Actions #17

Updated by Artem Kolychev over 4 years ago

artem/#915-entity-state-agenda
created table for audit entity states + test

Actions #18

Updated by Artem Kolychev over 4 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Artem Kolychev to Vít Švanda
Actions #19

Updated by Radek Tomiška over 4 years ago

  • Status changed from Resolved to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
Actions #20

Updated by Artem Kolychev over 4 years ago

https://github.com/bcvsolutions/CzechIdMng/compare/artem/%23915-entity-state-agenda?expand=1
Check list:
+ change order for new item in menu - schould be under events menu (see description).
+ change url on FE to '/entity-states' (see '/entity-events' for inspiration).
+ change new content name 'AuditEntityStateTable' to 'EntityStates' and move into 'event' folder (see 'EntityEvents' for inspiration).
+ remove used wildcard import in java classes (see contributing notes).
+ fix cs localization - contains en localization (content 'entityStates').
+ change localization for bulk action 'Remove selected state' => 'Remove selected states'
+ 'EntityStateDeleteBulkActionIntegrationTest' creates statesin class initialization as array list generalization - move creation of states into normal method (even warning is shown). See 'EntityEventDeleteBulkActionIntegrationTest' for inspiration.
+ Property 'detail' used for 'EntityStateTable' doesn't exist - should be removed.
+ Property 'uiKey' - use spinal-case (seee 'EntityEvents' for inspiration)

Actions #21

Updated by Artem Kolychev over 4 years ago

filter extension:
date filterare completed.
Modal and result code will be implemented in next task

Actions #22

Updated by Vít Švanda over 4 years ago

  • Target version changed from Rhyolite (9.7.5) to Rhyolite (9.7.6)
Actions #23

Updated by Radek Tomiška over 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Artem Kolychev
  • % Done changed from 80 to 100

I did test and code review, code is nice now, thx!

I fixed:
- Entity state agenda was registered under wrong menu (in audit sub menu) - i moved her into main menu and fixed routes and keys for localization,
- cs locale was copied from entity events - fixed,
- unexist properties are removed from ''EntityStates'' content.

Merged into develop:
https://github.com/bcvsolutions/CzechIdMng/commit/c3db2bf37e822554a7b11d44c23cf29a688395d7

Actions #24

Updated by Radek Tomiška over 4 years ago

  • Related to Task #1827: Entity state agenda: add result code column and filter by result state and code. added
Actions #25

Updated by Radek Tomiška over 4 years ago

  • Related to Task #1828: Entity state and entity event agenda - add available entity type select box. added
Actions #26

Updated by Artem Kolychev over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF