Project

General

Profile

Actions
Copy link

Task #862

closed

Add confirmation about starting a scheduled task

Added by Alena Peterová about 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Petr Adamec
Category:
Scheduler
Target version:
Garnet (7.7.0)
Start date:
12/01/2017
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Affects the version 7.6.0
When starting a scheduled task manually (Settings -> Task scheduler -> Scheduled tasks -> Actions -> Run manually), please add a confirmation modal window to prevent mistakes. Users should confirm running the task in the same way as they must confirm manually starting a synchronization from the Systems -> Synchronization.

Actions
Copy link
 #1

Updated by Alena Peterová about 7 years ago

  • Category set to Scheduler
Actions
Copy link
 #2

Updated by Marcel Poul almost 7 years ago

  • Assignee set to Petr Adamec
Actions
Copy link
 #3

Updated by Petr Adamec almost 7 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #4

Updated by Petr Adamec almost 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Petr Adamec to Ondřej Kopr
  • % Done changed from 0 to 100

I have added confirmation about starting a scheduled task and changed locale files

Actions
Copy link
 #5

Updated by Ondřej Kopr almost 7 years ago

  • % Done changed from 100 to 90

For next time please set percentage to 90% after successful feedback will be set to 100% and add some information about commits and branch where I find your solution.

TY.

Actions
Copy link
 #6

Updated by Ondřej Kopr almost 7 years ago

  • Assignee changed from Ondřej Kopr to Radek Tomiška

I made first feedback and I found some minor issues, that I already fixed:

  • localization message run_manually.action is unless, moreover the localization is bad 'SpustitRucne' and 'RunManually',
  • parameter count for your new message is unless from FE agenda I'm able strat only one task at time,
  • plural localization is for also unless, but I left them.

One think for next time, when you add some ticket to review set it 90% not 100% and please add some information about commits and branch, where I find your solution :)

Nice job modal window works as I except. Please Radek could you make a final review?

my commits: https://github.com/bcvsolutions/CzechIdMng/commit/10942b29b00d234ed54064222b7622f2be50756a
branch: https://github.com/bcvsolutions/CzechIdMng/tree/adamecp/862-Add-confirmation-about-starting-a-scheduled-task
pull request: https://github.com/bcvsolutions/CzechIdMng/pull/15

Actions
Copy link
 #7

Updated by Radek Tomiška almost 7 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Petr Adamec
  • Target version set to Garnet (7.7.0)
  • % Done changed from 90 to 100

I did test and feedback, thx for this feature. I fixed issues:
- confirm from delete method with wrong level (danger) was used
- duplicate localization key 'run_manually' was removed (success messages was not used, plural is not used too, but i left them like Ondra:)) - see 'task-run' key.
- the same confirm is added to dry run button

Actions
Copy link

Also available in: Atom PDF