Project

General

Profile

Actions

Task #807

closed

GUI: Can see others positions

Added by Lukáš Cirkva over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Frontend
Target version:
Start date:
11/02/2017
Due date:
% Done:

100%

Estimated time:
Owner:

Description

in demo.czechIDM.com

Users/user/Positions/Add new –>

In "Structure type:" choose: "Organization structure (ORG)"

BUG: in pull-down in "Positions" cant list more than 10, cant see more than 10.

more in screenshot


Files

Actions #1

Updated by Lukáš Cirkva over 6 years ago

  • Assignee deleted (Radek Tomiška)
Actions #2

Updated by Radek Tomiška over 6 years ago

When no input is given, then first page of result is shown. When you start typing into select box input, then another page with search result is shown. This is select box standard functionality. Loading another page of results automatically is not implemented.

Actions #3

Updated by Radek Tomiška over 6 years ago

  • Tracker changed from Defect to Task
Actions #4

Updated by Lukáš Cirkva over 6 years ago

Radek Tomiška wrote:

When no input is given, then first page of result is shown. When you start typing into select box input, then another page with search result is shown. This is select box standard functionality. Loading another page of results automatically is not implemented.

Understood, but. If the user does not know the query, the item does not have a chance to be selected. This is actually a bug for the user.

The component must be replaced as a functional one.

Actions #5

Updated by Radek Tomiška over 6 years ago

Maybe this can be solved different ways. I think pagination in select box has their reason - tree structure can be really big.

Possible solutions:
- we can configure page size for any select box separately- so we are able to set page size for positions to e.g. 100 on this page (implemented now)
- or think about loading another results page (automatically, on click to "more results" label, etc.)
- on this concrete page - some tree component would be nice maybe.

Actions #6

Updated by Ondřej Kopr over 6 years ago

  • Assignee set to Ondřej Kopr
Actions #7

Updated by Ondřej Kopr over 6 years ago

  • Status changed from New to In Progress

Good idea how to resolve loading next records into select is use waypoints (see https://www.npmjs.com/package/react-waypoint) Thanks Radek for you hint :).

I will start with loading next records by add button (event onClick to this button), after this behavior will works well, I add waypoints.

Actions #8

Updated by Ondřej Kopr over 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • Target version set to Forsterite (7.6.0)
  • % Done changed from 0 to 90

I create waypoint for reached last option in selectbox. Search also works with input and open and close selectbox.

Please Radek could you make a review? Thank you.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/d9582ec28b6ac021d37589e5e61972d37dfe432d

Actions #9

Updated by Vít Švanda over 6 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
Actions #10

Updated by Ondřej Kopr over 6 years ago

  • % Done changed from 90 to 70

Vitek founded mirror bug with merge force paramaeters with next page request, I will fix it.

Actions #11

Updated by Ondřej Kopr over 6 years ago

  • Status changed from In Progress to Needs feedback
  • % Done changed from 70 to 90

Thanks for report bug, I already fixed by add check for force search parameters.

commit: https://github.com/bcvsolutions/CzechIdMng/commit/2331d202e1865c1857cb21381236a8965cf95261

Please Vitek could you check your problem and then again add this ticket to Radek for feedback, thank you.

Actions #12

Updated by Ondřej Kopr over 6 years ago

  • Assignee changed from Ondřej Kopr to Vít Švanda
Actions #13

Updated by Vít Švanda over 6 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Ondřej Kopr
  • % Done changed from 90 to 100

I tested it and did review. Works fine.
This is very awesome functionality. Thanks for that.

Actions #14

Updated by Ondřej Kopr over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF