Task #72
closed
Zobrazení auditu pro identitu
Added by Vít Švanda over 8 years ago.
Updated over 8 years ago.
Description
- BE Rest for envers Envers:
- nová služba AuditService pro čtení auditních informací
- služba bude použita v konkrétních endpoitnech (identity, role ..)
- je potřeba se naučit využívat / přetežovat spring data rest processory pro konverzi entita - resource
- Zapojení na FE na detail Identity (jako nová záložka "Audit").
- Na nové záložce bude tabulka s datumy změny identity (kdy, kdo) a číslem verze (revize), a možností zobrazit historický záznam.
- Po kliku na historický záznam se sobrazí detail historické identity (bude přepoužit aktuální detail s informocí, že se jedná o historický záznam - v url na apříklad přes query parametr rev).
Nice to have: Dokázat vypsat pouze změny (změněné položky) na identitě mezi revizí (https://docs.jboss.org/hibernate/orm/4.2/devguide/en-US/html/ch15.html#envers-tracking-modified-entities-revchanges)
- Estimated time set to 32.00 h
- Description updated (diff)
- Status changed from New to In Progress
- Assignee set to Radek Tomiška
- Description updated (diff)
- Subject changed from Audit - FE to Zobrazení auditu pro identitu
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 0 to 60
Implementation BE, endpoints:
- /identities/<username>/revisions - get all revesions for username, include self link to detail of revision
- /identities/<username>/revisons/<revID> - get detail of revesions by revID
- Same endpoints are implements on entity Organizations and Roles
On BE is also implemened interface for controlers. With revisions getters.
- % Done changed from 60 to 90
Implementation FE
On agenda users was added new tab 'Audit' with info about revision. All informations about Identity revisions are show on table with id revision, date modification, modifier and button with detail revision.
On BE was added test AuditService on organization, for role and identity is process same.
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
After quick review found this mistate. Is nessesary to add exception to AuditService, exception on FE:
INTERNAL_SERVER_ERROR (500:12440182-9ea8-481d-a0bb-9e3ac22bb1ee)
Revision 102 does not exist.
After discussion it was implemented some changes:
- User tab with profile, working pos., etc. was hidden in audit
- Add error message, if not found revision
- Button save was hidden in audit
- Add better javadoc to interface IdmRevisionController
- Add test to controller on identity, role, organization
- Change url from audit to revision
- resolve conflict with ResultCodeException
After merge was all tests successful
- Status changed from Needs feedback to Resolved
It works smoothly now, thanks for agile corrections. Code looks nice, good job.
- Status changed from Resolved to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
Also available in: Atom
PDF