Project

General

Profile

Actions
Copy link

Task #723

closed

Create IdentitySelect and RoleSelect component

Added by Radek Tomiška over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Frontend
Target version:
Forsterite (7.6.0)
Start date:
09/27/2017
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Wrap selects for identity and role into new components (encapsulate manager setting, searchInFields etc.) and register them by component descriptor.

Related issues

Precedes IdStory Identity Manager - Defect #713: To many identities in selectboxClosedOndřej Kopr

Actions
Actions
Copy link
 #1

Updated by Radek Tomiška over 6 years ago

  • Precedes Defect #713: To many identities in selectbox added
Actions
Copy link
 #2

Updated by Ondřej Kopr over 6 years ago

  • Status changed from New to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
Actions
Copy link
 #3

Updated by Ondřej Kopr over 6 years ago

  • Target version set to Forsterite (7.6.0)
Actions
Copy link
 #4

Updated by Ondřej Kopr over 6 years ago

  • % Done changed from 0 to 90

I created new component EntitySelectBox, this component is now used only on RoleDetail guarantees (after success feedback, is possible add this component to another places)

Component EntitySelectBox uses information from component-descriptor and is possible, add searchInFields, manager, own component (default is SelectBox) and etc. see readme.

Please Radek could you make a review? Thank you :)
commit: https://github.com/bcvsolutions/CzechIdMng/commit/5485777a9424f0c1433c04a0d9b260842aa8cbde

Actions
Copy link
 #5

Updated by Ondřej Kopr over 6 years ago

  • Assignee changed from Ondřej Kopr to Radek Tomiška
Actions
Copy link
 #6

Updated by Ondřej Kopr over 6 years ago

  • Status changed from In Progress to Needs feedback

I forgot add needs feedback state, sorry :(

Actions
Copy link
 #7

Updated by Radek Tomiška over 6 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 80

I did test and review, it works and component registration is awesome!

I did some refactoring, some things remain:
- validation (required etc) doesn't work
- onChange parameter doesn't work (check all others AbstractFormComponent method and delegate them to inner select box component - the same as setValue, getValue)
- add localization to entity properties, which are shown in default help block

Actions
Copy link
 #8

Updated by Ondřej Kopr over 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 80 to 90
Thanks for feedback,
  • i override all necessary methods from AbstractFormComponent (focus, getRequiredValidationSchema, getValidationDefinition, isValid, onChange and validate)
  • also add localization for search in fields for help block,
  • + new functionality: add pageSize for module descriptor.

commits :
https://github.com/bcvsolutions/CzechIdMng/commit/4c988397dbe14c8eaf2d1f8595ffb722615a666c
https://github.com/bcvsolutions/CzechIdMng/commit/b08e93ef35ab6c795d9704cbffd2328c2ab83518

please Radek could you make next feedback? Thank you :)

Actions
Copy link
 #9

Updated by Vít Švanda over 6 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

Awesome, works and looks nice.

Actions
Copy link

Also available in: Atom PDF