Task #710
closed
Authentication with more provisioning mapping fails
100%
Description
When more than one provisioning mapping is defined on one system (e.g. for different entity type), then authentication by target system fails - exception occurs in repository query (SysSystemAttributeMappingRepository#findAuthenticationAttribute, SysSystemAttributeMappingRepository#findUidAttribute) - more records are found and only single record is expected. SystemEntityType parameter has to be added into method parameters and propagated higher - to authentication, where SystemEntityType.IDENTITY will be used as parameter value.
This change solves issue, when exists more mapping for different SystemEntityType. We need to add contraint - SystemEntityType should have only one provisioning mapping.
Updated by Ondřej Kopr over 7 years ago
- % Done changed from 0 to 90
Thanks for feedback, i was added new check for create system mapping and update method getAuthenticationAttribute.
commit: https://github.com/bcvsolutions/CzechIdMng/commit/38f7589934e9c2d066e387cefd6852001cbc5c78
Please Radek could you make a review?
Updated by Ondřej Kopr over 7 years ago
- Status changed from New to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
Updated by Ondřej Kopr over 7 years ago
Thanks for quick feedback, i fixed problem with duplicate mapping trough entities.
commit: https://github.com/bcvsolutions/CzechIdMng/commit/c0e9c9841737a637bc22c2e1cb9889d4c64b2f98
Updated by Radek Tomiška over 7 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
It works, thx! I've added some error message parameters, when constraint check fails.