Task #672
closed
Refactor tree services to use dto
100%
Description
Use IdmTreeTypeDto and IdmTreeNodeDto in service (event processors) and controller layer.
Updated by Radek Tomiška over 6 years ago
- % Done changed from 0 to 80
Tree nodes and types are refactored to dto usage.
Another features have to be implemented here:
- refactor default tree type configuration - its implemented as 'flag' on tree type - audit is skipped now, when default tree type and node is changed. Better will be configuration service usage.
- add security to read operations (now any logged identity can read types and nodes) - default role will be configured to add autocomplete permission.
Updated by Radek Tomiška over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 80 to 90
Default tree type configuration uses configuration service now, documentation:
https://github.com/bcvsolutions/CzechIdMng/blob/develop/CHANGELOG.md
https://wiki.czechidm.com/devel/dev/configuration/backend#tree
https://wiki.czechidm.com/devel/dev/organization/organization-structure
https://wiki.czechidm.com/devel/dev/contractual-relationship
Tree type and node endpoint are secured now. I updated default role setting documentation:
https://wiki.czechidm.com/devel/dev/security/authorization#default_settings_of_permissions_for_an_identity_profile
Could you pls do a review?
Updated by Ondřej Kopr over 6 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 90 to 100
I did review basic CRUD operation, synchronization tree structure and everything works perfect, while check tree synchronization i explored bug with synchronization item log, this was already fixed.
Thank you for transform tree to dto.
Updated by Radek Tomiška over 6 years ago
- Status changed from Resolved to Closed