Project

General

Profile

Actions

Defect #627

closed

Refactor query for email notification (recipient)

Added by Ondřej Kopr over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Notification
Target version:
Start date:
08/04/2017
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

Please refactor query for get emails and add indexes fro realRecipient.

Use case: When search email notifications and fill recipient, query for search is very slow (~5 minutes).


Files

email_test.png (2.17 KB) email_test.png Ondřej Kopr, 08/07/2017 11:01 AM
email_time.png (8.81 KB) email_time.png Ondřej Kopr, 08/07/2017 11:02 AM
Actions #2

Updated by Ondřej Kopr over 6 years ago

  • Target version changed from Diamond (7.4.0) to Citrine (7.3.0)

After discussion with implementator's team, change target version to Citrine.

Actions #3

Updated by Marcel Poul over 6 years ago

the result of the filter is also invalid. see previous url and usecase when I use user mpoul. The result I get consists of ALL sent emails (12721). The same number as with cleaned filter.

Actions #4

Updated by Radek Tomiška over 6 years ago

  • Status changed from New to In Progress
Actions #5

Updated by Radek Tomiška over 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 0 to 90

All repositories are using the same criteria api in AbstractNotificationLogService#toPredicates method. Query is much simpler now (exists parts is not needed now):
https://github.com/bcvsolutions/CzechIdMng/commit/7e305bdc251de8a085df88736adb57ae06b3b524

Could you do a feedback please?

Actions #6

Updated by Ondřej Kopr over 6 years ago

Awesome! I did test with ~13000 rows (same as projects) and query time is about 400ms! Thanks for refactor this query. Thanks.

Actions #7

Updated by Radek Tomiška over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF