Actions
Task #557
closed
If a filter is set, indicate it to user
Start date:
06/29/2017
Due date:
% Done:
100%
Estimated time:
Owner:
Description
Sometimes we are wondering, why IdM is not showing some data. And then find out, the filter is set. A suggestion is to highlight the filter button if a filter is set (for example with orange)
Files
Updated by Peter Štrunc almost 7 years ago
- Assignee changed from Radek Tomiška to Marek Klement
Updated by Marek Klement almost 7 years ago
- Status changed from New to Needs feedback
- Assignee changed from Marek Klement to Radek Tomiška
- % Done changed from 0 to 80
Changed color of filter button to orange when filter is set, also contain tooltip
Updated by Radek Tomiška almost 7 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Marek Klement
- % Done changed from 80 to 70
I did quick review, i found some issues:
- use i18n('..') for localization (https://github.com/bcvsolutions/CzechIdMng/blob/develop/Realization/frontend/czechidm-core/src/services/LocalizationService.md#any-abstractcontextcomponent-subclass). Add locales to prefix 'component.advanced.Table.*'
- rename variables- style to level, text to tooltip
- remove prop isFilterSet and propagate whole searchParameters into ToogleFilterButton component (filled filter values can be shown in tooltip in future)
- use 'info' level (warning is used for issues or dangerous operations)
- use {} brackets (https://github.com/bcvsolutions/CzechIdMng/blob/develop/CONTRIBUTING.md)
Updated by Marek Klement almost 7 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Marek Klement to Radek Tomiška
Fixed translation and add some other thing from review
Updated by Radek Tomiška almost 7 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Marek Klement
- Target version set to Citrine (7.3.0)
- % Done changed from 70 to 100
Thx! I've just fixed formatting, tests (null pointer) and added some new features into ToogleFilterButton component .
Branch is merged into develop.
Updated by Radek Tomiška almost 7 years ago
I've added ignoring force search parameters.
Actions