Project

General

Custom queries

Profile

Actions

Task #462

closed

Move Recaptcha support from reg module to core

Added by Peter Štrunc over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Peter Štrunc
Category:
Authentication / Authorization
Target version:
Start date:
06/09/2017
Due date:
06/09/2017
% Done:

90%

Estimated time:
Owner:

Description

Recaptcha is needed in many places throughout the IdM and in all these places the code handling recaptcha has to be duplicated. The aim of this ticket is to provide Recaptcha utils (frontend and backend) in core module, so that other modules can use it.


Related issues

Follows IdStory Identity Manager - Task #497: Recaptcha - create tests on backendClosedPeter Štrunc

Actions
Actions #1

Updated by Peter Štrunc over 7 years ago

  • % Done changed from 0 to 70

I moved Recaptcha support in core module and refactored reg module to reflect these changes. Implementation can be found in branch psourek/moveRecaptcha on both repositories. I also added config initialization in setup.js so that we can use config in our components and still be able to run tests on them.

Please provide feedback. Thanks

Actions #3

Updated by Radek Tomiška over 7 years ago

I did test and review. Component is working now, i did corrections:
- rest controller for recaptcha was missing
- npm dependencieswere missing in package.json
- fixed some formatting issues (brackets, linter, we are usign identity operator === ...)
- change configuration keys on BE and FE
- docs added - recaptcha readme and https://proj.bcvsolutions.eu/ngidm/doku.php?id=en:navrh:konfigurace_aplikace#security
- error result codes added
- add standard form component features (validations etc.)

I've merged it to the develop branch. Could you add some test (integration or unit test with mock RecaptchaResponse) to BE, please?

Actions #6

Updated by Radek Tomiška over 7 years ago

  • Status changed from In Progress to Closed

Recaptcha was merged, component is used in other modules, thx. Test will be added in #497.

Actions

Also available in: Atom PDF