Task #462
closed
Move Recaptcha support from reg module to core
90%
Description
Recaptcha is needed in many places throughout the IdM and in all these places the code handling recaptcha has to be duplicated. The aim of this ticket is to provide Recaptcha utils (frontend and backend) in core module, so that other modules can use it.
Related issues
Updated by Peter Štrunc over 7 years ago
- % Done changed from 0 to 70
I moved Recaptcha support in core module and refactored reg module to reflect these changes. Implementation can be found in branch psourek/moveRecaptcha on both repositories. I also added config initialization in setup.js so that we can use config in our components and still be able to run tests on them.
Please provide feedback. Thanks
Updated by Peter Štrunc over 7 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Peter Štrunc to Radek Tomiška
Updated by Radek Tomiška over 7 years ago
I did test and review. Component is working now, i did corrections:
- rest controller for recaptcha was missing
- npm dependencieswere missing in package.json
- fixed some formatting issues (brackets, linter, we are usign identity operator === ...)
- change configuration keys on BE and FE
- docs added - recaptcha readme and https://proj.bcvsolutions.eu/ngidm/doku.php?id=en:navrh:konfigurace_aplikace#security
- error result codes added
- add standard form component features (validations etc.)
I've merged it to the develop branch. Could you add some test (integration or unit test with mock RecaptchaResponse) to BE, please?
Updated by Radek Tomiška over 7 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Peter Štrunc
- % Done changed from 70 to 90
Updated by Radek Tomiška over 7 years ago
- Due date set to 06/09/2017
- Start date changed from 05/31/2017 to 06/09/2017
- Follows Task #497: Recaptcha - create tests on backend added
Updated by Radek Tomiška over 7 years ago
- Status changed from In Progress to Closed
Recaptcha was merged, component is used in other modules, thx. Test will be added in #497.