Project

General

Profile

Actions

Defect #3360

closed

Role request does not contains info about tech account

Added by David Štekl over 1 year ago. Updated 11 months ago.

Status:
Closed
Priority:
High
Assignee:
Peter Štrunc
Category:
Technical and other accounts
Target version:
Start date:
05/10/2023
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:
Peter Štrunc

Description


Files

Actions #1

Updated by Peter Štrunc over 1 year ago

  • Target version changed from 13.0.5 to 13.0.6
Actions #2

Updated by Peter Štrunc over 1 year ago

  • Status changed from New to In Progress
  • Assignee set to Peter Štrunc
  • Owner set to Peter Štrunc
Actions #3

Updated by Peter Štrunc over 1 year ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Peter Štrunc to Ondřej Kopr
  • % Done changed from 0 to 80

https://github.com/bcvsolutions/CzechIdMng/pull/397

Fixed. @kopro could you check it out, please?

Actions #4

Updated by Alena Peterová over 1 year ago

The role request table contains the info about tech account correctly now, thanks.
I found out that when I create a new role request for a technical account, the info about account in the request doesn't look well (there is not info card, just line with the account's name). When I click on the account's name, I get empty account detail with message "Entity not found".
Please could you check it again @sourek


Jun 21 16:23:06 idmsnt czechidm[997]: 2023-06-21 16:23:06.277  INFO 13833347 --- [http-nio-8080-exec-8] eu.bcvsolutions.idm.core.exception.ExceptionControllerAdvice.log : [core:ENTITY_NOT_FOUND:36c2fb9f-77ed-41b3-a16f-e8781f4b41db] Entity type [eu.bcvsolutions.idm.acc.entity.AccAccount] with id [undefined] not found. ({entityType=eu.bcvsolutions.idm.acc.entity.AccAccount, entityId=undefined})
Jun 21 16:23:06 idmsnt czechidm[997]: eu.bcvsolutions.idm.core.api.exception.EntityNotFoundException: Entity type [eu.bcvsolutions.idm.acc.entity.AccAccount] with id [undefined] not found.
Jun 21 16:23:06 idmsnt czechidm[997]: #011at eu.bcvsolutions.idm.core.api.rest.AbstractReadDtoController.get(AbstractReadDtoController.java:133)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at eu.bcvsolutions.idm.acc.rest.impl.AccAccountController.get(AccAccountController.java:216)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at eu.bcvsolutions.idm.acc.rest.impl.AccAccountController$$FastClassBySpringCGLIB$$491c12f0.invoke(<generated>)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:752)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:88)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at eu.bcvsolutions.idm.core.security.service.impl.EnabledAspect.checkBeanEnabled(EnabledAspect.java:52)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at jdk.internal.reflect.GeneratedMethodAccessor194.invoke(Unknown Source)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at java.base/java.lang.reflect.Method.invoke(Method.java:566)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(AbstractAspectJAdvice.java:644)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethod(AbstractAspectJAdvice.java:633)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.aop.aspectj.AspectJAroundAdvice.invoke(AspectJAroundAdvice.java:70)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:69)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:93)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
Jun 21 16:23:06 idmsnt czechidm[997]: #011at eu.bcvsolutions.idm.acc.rest.impl.AccAccountController$$EnhancerBySpringCGLIB$$6f70ada2.get(<generated>)

Actions #5

Updated by Peter Štrunc over 1 year ago

Thanks for testing @apeterova. The issue you mention was fixed in #3361, but since it is not reviewed yet, I haven't included it in the build of the technical accounts module you are testing with. Let me know, if I should provide you a build of idm-tech module with the fix included.

Actions #6

Updated by Alena Peterová over 1 year ago

Finally, I can confirm that the link to the technical account works well. Thank you.
I approved the merge request, but I can't merge it, please merge it yourself.


Note: I spent way too much time on this, when I built the newer version of idm-tech with the branch pstrunc/3361_tech_acc_info_fix. I still saw "NULL" when creating a role request for a new technical account. Also the tab "Technical account" and "Guarantors" were broken (empty) and role requests displayed all concepts in the system. In the end, I found out that I have wrong configuration of the provisioning mapping for technical accounts! I used "entity type = Identity" and "account type = Technical". This is wrong, you have to select "entity type = Technical account".

Actions #7

Updated by Peter Štrunc over 1 year ago

I created a ticket for the issue you mentioned #3403
PR is merged

Resolving this ticket

Actions #8

Updated by Peter Štrunc over 1 year ago

  • Status changed from Needs feedback to Resolved
  • % Done changed from 80 to 100
Actions #9

Updated by Peter Štrunc 11 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF