Project

General

Profile

Actions
Copy link

Feature #3340

closed

Force remove roles option on recertification

Added by Peter Štrunc over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Luboš Čábelka
Target version:
3.2.0
Start date:
04/19/2023
Due date:
% Done:

100%

Estimated time:
Owner:
Actions
Copy link
 #1

Updated by Peter Štrunc over 1 year ago

  • Tracker changed from Task to Feature
Actions
Copy link
 #2

Updated by Ondřej Kopr over 1 year ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Ondřej Kopr over 1 year ago

  • Target version changed from 2.4.0 to 3.2.0

Feature will be provided in version 3.2.0

Actions
Copy link
 #5

Updated by Ondřej Kopr over 1 year ago

  • % Done changed from 0 to 10
Actions
Copy link
 #6

Updated by Ondřej Kopr over 1 year ago

  • % Done changed from 10 to 60

Recertification was pushed into my branch in first working version

Branch: https://git.bcvsolutions.eu/modules/recertification/-/tree/okopr/3340-force-recertification

Missing documentation, tests and review.

From implementation comes some question:
  • for removing was implemented new LRT - the LRT counts request not items,
  • roles removing is synchronous,
  • roles remove execution can be setup via LRT with "after date" configuration,
  • force recertification was translated in CZ: Tvrdá recertifikace, EN: Hard recertification,
  • LRT for removing isn't initialized by default,
  • recertification request is editable after start recertification (this exists also in previous versions).
Actions
Copy link
 #7

Updated by Ondřej Kopr over 1 year ago

After first review Vlada found issue with propagation force flag into backend.

This issue was fixed.

Commit: https://git.bcvsolutions.eu/modules/recertification/-/commit/e92af1dd74ed64711b246c0c14295554a704eac4 (branch: lcabelka/3399-merge-branch)

Actions
Copy link
 #8

Updated by Ondřej Kopr over 1 year ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Luboš Čábelka
  • % Done changed from 60 to 90

Tests takes me little bit longer than I except.

But there are: https://git.bcvsolutions.eu/modules/recertification/-/commit/0906fb388dd3625d71542b7009eff5222e9a0fc0 (branch: lcabelka/3399-merge-branch)

Documentation was updated: https://wiki.czechidm.com/tutorial/adm/module_recertification

Please Luboš could you provide me the feedback? Thank you.

Actions
Copy link
 #9

Updated by Luboš Čábelka over 1 year ago

  • Status changed from Needs feedback to Resolved
  • % Done changed from 90 to 100

I did review, all looks great.
Added frontend localization for long running task (cs and en).

Actions
Copy link
 #10

Updated by Peter Štrunc about 1 year ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF