Project

General

Profile

Actions
Copy link

Task #3271

closed

Task #3270: Upgrade Spring Boot

Spring Boot 2.1 > 2.2

Added by Tomáš Doischer about 1 year ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Peter Štrunc
Category:
Maintenance
Target version:
13.1.0
Start date:
03/07/2023
Due date:
% Done:

100%

Estimated time:
60.00 h
Owner:
Peter Štrunc

Description

Pretty massive changes in this version. There may be some painful refactoring.

https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.2-Release-Notes

Actions
Copy link
 #1

Updated by Tomáš Doischer about 1 year ago

  • Parent task set to #3270
Actions
Copy link
 #2

Updated by Tomáš Doischer about 1 year ago

  • Description updated (diff)
  • Estimated time set to 60.00 h
Actions
Copy link
 #3

Updated by Tomáš Doischer about 1 year ago

  • Sprint set to Sprint 13.1-2 (bře 08 - bře 22)
  • Assignee set to Tomáš Doischer
Actions
Copy link
 #4

Updated by Tomáš Doischer about 1 year ago

  • Status changed from New to In Progress
Actions
Copy link
 #5

Updated by Tomáš Doischer about 1 year ago

  • Category set to Maintenance
  • % Done changed from 0 to 50

Current state:

  • Flyway (5 > 6) now works but a minor change in each module is needed
  • Quartz did not work at some point but now seems to work fine
  • massive changes in HATEOAS - I used a migration shell script supplied by Spring but it is a little trigger happy so a little more careful replacement will be used for standard module migration
  • REST API does not quite work
Actions
Copy link
 #6

Updated by Tomáš Doischer about 1 year ago

Swagger needs to be upgraded to 3.0.0.

Actions
Copy link
 #7

Updated by Tomáš Doischer about 1 year ago

  • % Done changed from 50 to 70

The application now starts and works roughly as expected.

Tests needed some change in flyway config (just disabling flyway is not enough) and now seem to work well.

Swagger currently does not work.

Actions
Copy link
 #8

Updated by Tomáš Doischer about 1 year ago

  • Sprint changed from Sprint 13.1-2 (bře 08 - bře 22) to Sprint 13.1-3 (bře 22 - dub 05)
Actions
Copy link
 #9

Updated by Tomáš Doischer about 1 year ago

Swagger works.

Ic module has no description for some reason.
LRTs do cannot be started.

Actions
Copy link
 #10

Updated by Tomáš Doischer about 1 year ago

The issue with nonstarting LRTs was caused by the shift to lazy bean initialization (by default!!!) in 2.2. As a result, annotation processing looked at interfaces an not proxies. LRTs work fine now.

Some tests are failing due to changes in Mockito and will require rewriting, @InjectMock does not work as it used to.

Actions
Copy link
 #11

Updated by Tomáš Doischer about 1 year ago

  • Sprint changed from Sprint 13.1-3 (bře 22 - dub 05) to Sprint 13.1-4 (dub 05 - dub 19)
Actions
Copy link
 #12

Updated by Tomáš Doischer about 1 year ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Tomáš Doischer to Peter Štrunc
  • % Done changed from 70 to 80

All tests finally passed.

PR: https://github.com/bcvsolutions/CzechIdMng/pull/349

Can you take a look?

Actions
Copy link
 #13

Updated by Tomáš Doischer about 1 year ago

  • Sprint changed from Sprint 13.1-4 (dub 05 - dub 19) to Sprint 13.1-5 (dub 19 - kvě 03)
Actions
Copy link
 #14

Updated by Peter Štrunc 8 months ago

  • Sprint changed from Sprint 13.1-5 (Apr 19 - May 03) to Appliance / Cross domain / IdStory Hub - 9 (Sep 18 - Oct 02)
Actions
Copy link
 #15

Updated by Peter Štrunc 7 months ago

  • Status changed from Needs feedback to Resolved
  • % Done changed from 80 to 100
  • Owner set to Peter Štrunc

Looks good. Needed to fix a few test and rebase on current develop. Merged. Closing ticket

Actions
Copy link
 #16

Updated by Martin Kolombo 6 months ago

  • Sprint changed from Appliance / Cross domain / IdStory Hub - 9 (Sep 18 - Oct 02) to Next Backlog (Oct 30 - Nov 13)
Actions
Copy link
 #17

Updated by Peter Štrunc 6 months ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF