Project

General

Profile

Actions

Task #3197

closed

RC testing, bugfixes before full release

Added by Roman Kučera over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomáš Doischer
Category:
Release
Target version:
Start date:
09/16/2022
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Bugs, issues found during development or during RC testing

Tests suggestion: connect an AD and manage group membership. Is the account details reasonable for this?


Files

image (6).png (35.2 KB) image (6).png Tomáš Doischer, 01/02/2023 01:18 PM
Screenshot from 2023-01-16 09-45-54.png (29.1 KB) Screenshot from 2023-01-16 09-45-54.png Tomáš Doischer, 01/16/2023 08:46 AM
clipboard-202301160953-idcfh.png (61.6 KB) clipboard-202301160953-idcfh.png Tomáš Doischer, 01/16/2023 08:53 AM
Screenshot from 2023-01-16 10-26-39.png (21.2 KB) Screenshot from 2023-01-16 10-26-39.png Tomáš Doischer, 01/16/2023 09:28 AM
Actions #1

Updated by Roman Kučera over 1 year ago

Use case:
  • system which was created before version 12.3.0
  • open this system in wizard
  • When you choosing object in IdM = E.g Identity, Role, Tree, ... you need to reselect this type, otherwise you get an error and you can't continue to next step (this issue is every time I open existing system in wizard)
  • Step with synchronization showing message "Type of sync configuration, cannot be changed!
    Type of sync configuration, cannot be changed!"

Fixed.
Fixed in https://github.com/bcvsolutions/CzechIdMng/pull/282 along with note number 2 and 5 (same issue).

Actions #2

Updated by Roman Kučera over 1 year ago

28.9.
On develop branch - when creating new mapping you need to reselect entity type, otherwise null is send to backend for some reason.
You are not able to change account type for already existing mapping due to issue mentioned above.

Fixed. See note 1.

Actions #3

Updated by Tomáš Doischer over 1 year ago

Tests are currently failing in develop and need to be fixed.

Actions #4

Updated by Tomáš Doischer over 1 year ago

Mapping duplication creates a synchronization mapping even from a provisioning mapping. This duplication will be pretty useful for managing other accounts so it should be improved.

Fixed.
Fixed in https://github.com/bcvsolutions/CzechIdMng/pull/283.

Actions #5

Updated by Tomáš Doischer over 1 year ago

Wizards for systems do not work. The mapping cannot be saved because the entity type is null.

Fixed. See note 1.

Actions #6

Updated by Roman Kučera over 1 year ago

You are not able to create login role for technical account mapping
issue is in DefaultSysRoleSystemService::save line 152

Fixed.
Fixed in https://github.com/bcvsolutions/CzechIdMng/pull/284.

Actions #7

Updated by Tomáš Doischer over 1 year ago

  • Sprint set to Sprint 12.3-9 (lis 23 - pro 07)
  • Assignee changed from Roman Kučera to Tomáš Doischer

Set priorities - fix the major ones.

Actions #8

Updated by Tomáš Doischer over 1 year ago

  • Status changed from New to In Progress
Actions #9

Updated by Tomáš Doischer over 1 year ago

Actions #10

Updated by Tomáš Doischer over 1 year ago

  • Sprint changed from Sprint 12.3-9 (lis 23 - pro 07) to Sprint 12.3-10 (pro 07 - pro 21)
Actions #11

Updated by Tomáš Doischer over 1 year ago

  • Assignee changed from Tomáš Doischer to Evgeniya Gorina
Actions #12

Updated by Peter Štrunc over 1 year ago

  • % Done changed from 0 to 50

Merged all of the PRs above. Looks great, thanks for fixing all this stuff. Keeping ticket open in case some other bugs show up during RC testing.

Actions #13

Updated by Peter Štrunc over 1 year ago

Backward compatibility for IdmRoleRequest is broken since filed applicant was changed from being of type UUID to ApplicantDto. Problem is with deserialization of old role requests from activity workflow tables. Solution would be to keep applicant field as UUID and introduce new filed applicantInfo

Actions #14

Updated by Peter Štrunc over 1 year ago

There are some issues with current develop relating flyway and db schema
- collision in migration script names
- Missing migration for applicant_type column
- Missing imports

All fixed in https://github.com/bcvsolutions/CzechIdMng/pull/290. @doischert would you check it out, please?

Actions #15

Updated by Tomáš Doischer over 1 year ago

Actions #16

Updated by Tomáš Doischer over 1 year ago

Role deduplication removes roles for other accounts which leads to their removal.

Fixed .

Fixed in https://github.com/bcvsolutions/CzechIdMng/pull/294.

Actions #17

Updated by Tomáš Doischer over 1 year ago

Minor frontend strangeness.

Fixed. (Doesn't happen anymore.)

Actions #18

Updated by Tomáš Doischer over 1 year ago

Identity recalculate and provisioning bulk action doesn't work with multiple personal accounts.

Fixed.

Fixed in https://github.com/bcvsolutions/CzechIdMng/pull/292

Actions #19

Updated by Tomáš Doischer over 1 year ago

Merge attributes for multiple accounts do not work and are sent to all accounts.

Actions #20

Updated by Tomáš Doischer over 1 year ago

The first tabs in FE are not preselected.

Note: this happens only for system mappings.

Fixed.

Actions #21

Updated by Tomáš Doischer over 1 year ago

DefaultAccAcccountManagementService#431 still tries to find a contract and fails during delete.

Actions #22

Updated by Peter Štrunc over 1 year ago

Tomáš Doischer wrote in #note-20:

The first tabs in FE are not preselected.

Note: this happens only for system mappings.

Fixed in https://github.com/bcvsolutions/CzechIdMng/pull/293. Would you check it out, please?

Actions #23

Updated by Tomáš Doischer over 1 year ago

Peter Štrunc wrote in #note-22:

Tomáš Doischer wrote in #note-20:

The first tabs in FE are not preselected.

Note: this happens only for system mappings.

Fixed in https://github.com/bcvsolutions/CzechIdMng/pull/293. Would you check it out, please?

Awesome, thank you. Merged to develop.

Actions #24

Updated by Peter Štrunc over 1 year ago

In current develop, there is a cyclic dependency between services:

   acc-provisioning-operation-monitoring-evaluator (field private eu.bcvsolutions.idm.acc.service.api.SysProvisioningOperationService eu.bcvsolutions.idm.acc.monitoring.ProvisioningOperationMonitoringEvaluator.provisioningOperationService)
      ↓
   defaultSysProvisioningOperationService (field private eu.bcvsolutions.idm.acc.service.api.SysProvisioningArchiveService eu.bcvsolutions.idm.acc.service.impl.DefaultSysProvisioningOperationService.provisioningArchiveService)
      ↓
   defaultSysProvisioningArchiveService (field private eu.bcvsolutions.idm.acc.service.api.SysSystemEntityService eu.bcvsolutions.idm.acc.service.impl.DefaultSysProvisioningArchiveService.systemEntityService)
      ↓
   sysSystemEntityService (field private eu.bcvsolutions.idm.acc.service.api.SysSystemService eu.bcvsolutions.idm.acc.service.impl.DefaultSysSystemEntityService.systemService)
┌─────┐
|  defaultSysSystemService defined in URL [jar:file:/opt/tomcat/apache-tomcat-9.0.70/webapps/idm/WEB-INF/lib/idm-acc-12.3.0-SNAPSHOT.jar!/eu/bcvsolutions/idm/acc/service/impl/DefaultSysSystemService.class]
↑     ↓
|  defaultSysSyncConfigService (field private eu.bcvsolutions.idm.acc.service.api.SysSystemAttributeMappingService eu.bcvsolutions.idm.acc.service.impl.DefaultSysSyncConfigService.systemAttributeMappingService)
↑     ↓
|  defaultSysSystemAttributeMappingService (field private eu.bcvsolutions.idm.acc.service.api.AccAccountService eu.bcvsolutions.idm.acc.service.impl.DefaultSysSystemAttributeMappingService.accountService)
↑     ↓
|  accAccountService defined in URL [jar:file:/opt/tomcat/apache-tomcat-9.0.70/webapps/idm/WEB-INF/lib/idm-acc-12.3.0-SNAPSHOT.jar!/eu/bcvsolutions/idm/acc/service/impl/DefaultAccAccountService.class]
└─────┘
Actions #25

Updated by Peter Štrunc over 1 year ago

Peter Štrunc wrote in #note-24:

In current develop, there is a cyclic dependency between services:

[...]

Fixed here https://github.com/bcvsolutions/CzechIdMng/pull/296 would you check it out @doischert, please?

Actions #26

Updated by Peter Štrunc over 1 year ago

Tomáš Doischer wrote in #note-19:

Merge attributes for multiple accounts do not work and are sent to all accounts.

Fixed here https://github.com/bcvsolutions/CzechIdMng/pull/297. Would you review these changes @doischert, please?

Actions #27

Updated by Tomáš Doischer over 1 year ago

Peter Štrunc wrote in #note-26:

Tomáš Doischer wrote in #note-19:

Merge attributes for multiple accounts do not work and are sent to all accounts.

Fixed here https://github.com/bcvsolutions/CzechIdMng/pull/297. Would you review these changes @doischert, please?

LGTM, merged to develop.

Actions #28

Updated by Peter Štrunc over 1 year ago

Tomáš Doischer wrote in #note-21:

DefaultAccAcccountManagementService#431 still tries to find a contract and fails during delete.

Fixed here https://github.com/bcvsolutions/CzechIdMng/pull/298.

Would you check it out @doischert, please?

Actions #29

Updated by Tomáš Doischer over 1 year ago

Peter Štrunc wrote in #note-28:

Tomáš Doischer wrote in #note-21:

DefaultAccAcccountManagementService#431 still tries to find a contract and fails during delete.

Fixed here https://github.com/bcvsolutions/CzechIdMng/pull/298.

Would you check it out, please?

LGTM, merged to develop.

Actions #30

Updated by Tomáš Doischer over 1 year ago

  • Description updated (diff)

Error during start:

2023-01-05 16:21:49.302  WARN 33171 --- [main] eu.bcvsolutions.idm.core.scheduler.config.SchedulerConfig.schedulerManager : Job [default.4f8f136e7682-13fe0a10-9bf4-4c16-b1b6-d41d6aaf4d7e] inicialization failed, scheduled task is removed
java.lang.NoSuchMethodException: eu.bcvsolutions.idm.core.scheduler.task.impl.IdentityRoleValidRequestTaskExecutor.<init>()

The task can be found in IdM but not run.

Fixed here: https://github.com/bcvsolutions/CzechIdMng/pull/323

LGTM, merged to develop.

Actions #31

Updated by Tomáš Doischer over 1 year ago

For the account wizard, nothing happens after the wizard is finished. The account is created asynchronously so maybe showing a detail is not easy but the table could be refreshed.

Actions #32

Updated by Tomáš Doischer over 1 year ago

After assigning an account role via the account detail, the filter in the role request detail is probably stuck. When you then open a new role request normally from the identity detail, only account assignments are shown.

Fixed here: https://github.com/bcvsolutions/CzechIdMng/pull/320

LGTM, merged to develop.

Actions #33

Updated by Tomáš Doischer over 1 year ago

The account detail should show that merge attributes are managed by roles. This does not work for authoritative merge.

I was not able to reproduce this issue.

Won't fix

Actions #34

Updated by Tomáš Doischer over 1 year ago

Edit and refresh buttons in the account detail are not responsive and do not scale well.

Fixed here https://github.com/bcvsolutions/CzechIdMng/pull/309.

Actions #35

Updated by Tomáš Doischer over 1 year ago

Typos in Czech localization, "Gratulejeme" is used in wizards (both acc and tech module).

Fixed.

PR: https://github.com/bcvsolutions/CzechIdMng/pull/305
PR: https://git.bcvsolutions.eu/modules/technical-accounts/-/merge_requests/14

Actions #36

Updated by Tomáš Doischer over 1 year ago

When an account is not available, the account detail should say so. Right now, it just shows an empty page and keeps loading.

Fixed.

Fixed in https://github.com/bcvsolutions/CzechIdMng/pull/303

Actions #37

Updated by Tomáš Doischer over 1 year ago

Consider adding tech account guarantor information to user detail. The same for system owners.

Actions #38

Updated by Tomáš Doischer over 1 year ago

System > Roles - entity type is empty. It should say stuff like Identity, Role etc.

This also doesn't work in the mapping table and system entities.

Fixed. However, I left the system entity type unlocalized for system entities. This is a pretty technical table and localization would be a bit challenging to get here with multiple requests.

PR: https://github.com/bcvsolutions/CzechIdMng/pull/304

Actions #39

Updated by Tomáš Doischer over 1 year ago

  • Description updated (diff)
Actions #40

Updated by Tomáš Doischer over 1 year ago

System import now fails when importing mappings.

Fixed.

PR: https://github.com/bcvsolutions/CzechIdMng/pull/306

Actions #41

Updated by Tomáš Doischer over 1 year ago

  • Sprint changed from Sprint 12.3-10 (pro 07 - led 11) to Sprint 12.3-11 (led 11 - led 25)
Actions #42

Updated by Tomáš Doischer over 1 year ago

  • Assignee changed from Evgeniya Gorina to Tomáš Doischer
Actions #43

Updated by Peter Štrunc over 1 year ago

Tomáš Doischer wrote in #note-34:

Edit and refresh buttons in the account detail are not responsive and do not scale well.

Fixed here https://github.com/bcvsolutions/CzechIdMng/pull/309. Would you check it out @doischert, please?

Actions #44

Updated by Tomáš Doischer over 1 year ago

Peter Štrunc wrote in #note-43:

Tomáš Doischer wrote in #note-34:

Edit and refresh buttons in the account detail are not responsive and do not scale well.

Fixed here https://github.com/bcvsolutions/CzechIdMng/pull/309. Would you check it out, please?

Merged to develop, LGTM.

Actions #45

Updated by Tomáš Doischer over 1 year ago

Identity detail is missing some tabs:

  • password
  • permission
  • delegation
  • audit
  • maybe more?

Fixed here https://github.com/bcvsolutions/CzechIdMng/pull/311

Actions #46

Updated by Tomáš Doischer over 1 year ago

Role detail is missing the audit and automatic roles tab.

Fixed here https://github.com/bcvsolutions/CzechIdMng/pull/311

Actions #47

Updated by Tomáš Doischer over 1 year ago

When you're requesting a role, assign without approval is checked by default (it shouldn't be) even for non-admin users. It then fails.

Fixed .

PR: https://github.com/bcvsolutions/CzechIdMng/pull/310

Actions #48

Updated by Tomáš Doischer over 1 year ago

When sending an empty role request, an error will occur:

"IDMROLEREQUEST_APPLICANT_NOTNULL (400:a055fe6f-32cb-40d9-a8d2-44203ce1faef)
cannot be null (objectName:IdmRoleRequest, field:applicant, code:NotNull)"

Fixed here https://github.com/bcvsolutions/CzechIdMng/pull/315

LGTM, merged to develop.

Actions #49

Updated by Tomáš Doischer over 1 year ago

After IdM update, existing accounts have no account type set.

Actions #50

Updated by Tomáš Doischer over 1 year ago

Account detail could/should use space better, see the screenshot.

Multivalued attributes could also work better - while you can always expect that the line will be split, maybe suggesting that a new line is starting is possible with some dot.

Implemented.

PR: https://github.com/bcvsolutions/CzechIdMng/pull/313

Actions #51

Updated by Tomáš Doischer over 1 year ago

The form definition agenda is huge. Not anymore, this was likely something broken in the browser/testing env. Won't fix.

Actions #53

Updated by Tomáš Doischer over 1 year ago

Role requests in the identity role table are not filtered for the selected identity. All role requests are shown.

Fixed here: https://github.com/bcvsolutions/CzechIdMng/pull/316

LGTM, merged to develop.

Actions #54

Updated by Tomáš Doischer over 1 year ago

The test case scenarios were finished. No issues found, some minor FE issues were logged here.

Actions #55

Updated by Tomáš Doischer over 1 year ago

In the identity role table, identity role detail cannot be opened. Error:

2023-01-17 13:39:45.911 ERROR 4410853 --- [http-nio-8080-exec-10] eu.bcvsolutions.idm.core.exception.ExceptionControllerAdvice.log : [core:INTERNAL_SERVER_ERROR:d7746854-89c9-4d00-a1ba-35a572db8b5b] Identity identifier is required. ({})
java.lang.IllegalArgumentException: Identity identifier is required.
    at org.springframework.util.Assert.notNull(Assert.java:198)
    at eu.bcvsolutions.idm.core.model.service.impl.adapter.DefaultRequestRoleConceptAdapter.getAssignments(DefaultRequestRoleConceptAdapter.java:103)
    at eu.bcvsolutions.idm.core.model.service.impl.adapter.DefaultRequestRoleConceptAdapter.transform(DefaultRequestRoleConceptAdapter.java:78)
    at eu.bcvsolutions.idm.core.model.service.util.MultiSourcePagedResource.lambda$find$1(MultiSourcePagedResource.java:98)
    at eu.bcvsolutions.idm.core.model.service.util.MultiSourcePagedResource.doPaging(MultiSourcePagedResource.java:131)
    at eu.bcvsolutions.idm.core.model.service.util.MultiSourcePagedResource.find(MultiSourcePagedResource.java:93)
    at eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmRequestIdentityRoleService.find(DefaultIdmRequestIdentityRoleService.java:114)
    at eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmRequestIdentityRoleService.find(DefaultIdmRequestIdentityRoleService.java:44)
    at eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmRequestIdentityRoleService$$FastClassBySpringCGLIB$$f31c770b.invoke(<generated>)
    at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
    at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:687)
    at eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmRequestIdentityRoleService$$EnhancerBySpringCGLIB$$3fad752a.find(<generated>)
    at eu.bcvsolutions.idm.core.api.rest.AbstractReadDtoController.findWithOperator(AbstractReadDtoController.java:323)
    at eu.bcvsolutions.idm.core.api.rest.AbstractReadDtoController.find(AbstractReadDtoController.java:310)
    at eu.bcvsolutions.idm.core.rest.impl.IdmRequestIdentityRoleController.find(IdmRequestIdentityRoleController.java:127)
    at eu.bcvsolutions.idm.core.rest.impl.IdmRequestIdentityRoleController.find(IdmRequestIdentityRoleController.java:53)
    at eu.bcvsolutions.idm.core.api.rest.AbstractReadDtoController.find(AbstractReadDtoController.java:217)
    at eu.bcvsolutions.idm.core.rest.impl.IdmRequestIdentityRoleController.find(IdmRequestIdentityRoleController.java:85)
    at eu.bcvsolutions.idm.core.api.rest.AbstractReadDtoController.findQuick(AbstractReadDtoController.java:245)
    at eu.bcvsolutions.idm.core.rest.impl.IdmRequestIdentityRoleController.findQuick(IdmRequestIdentityRoleController.java:102)
    at eu.bcvsolutions.idm.core.rest.impl.IdmRequestIdentityRoleController$$FastClassBySpringCGLIB$$b12cf269.invoke(<generated>)
...

Fixed here: https://github.com/bcvsolutions/CzechIdMng/pull/316

LGTM, merged to develop.

Actions #56

Updated by Tomáš Doischer over 1 year ago

The audit doesn't use the info components for AccAccount.

Fixed.

PR: https://github.com/bcvsolutions/CzechIdMng/pull/314

Actions #57

Updated by Peter Štrunc over 1 year ago

Missing flyway script for acc_account_role_valid_req

Fixed here: https://github.com/bcvsolutions/CzechIdMng/pull/317

LGTM, merged to develop.

Actions #58

Updated by Tomáš Doischer about 1 year ago

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100

Released.

Actions #59

Updated by Tomáš Doischer about 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF