Task #3169
closed
Add new notification properties into ContractStartNotificationTask and LastContractEndNotificationTask
100%
Description
Add new properties which are available in notification template
New properties should be added into ContractStartNotificationTask and LastContractEndNotificationTask
Use properties from ContractChangeNotificationTask
Updated by Roman Kučera over 2 years ago
- % Done changed from 0 to 80
Implemented in https://github.com/bcvsolutions/czechidm-extras/tree/kucerar/3169-new-properties-in-notif-lrt
PR https://github.com/bcvsolutions/czechidm-extras/pull/83
LRTs ContractStartNotificationTask and LastContractEndNotificationTask are now using metadaFactory and all 3 notifications has the same way of calculating of params.
I also fixed utils method for EAV map. The issue was when some EAV is multivalued or has same code the map was not complete.
Now in case the code is alredy in map the next value is appended with comma separator.
@doischert Can you do a review please?
Updated by Roman Kučera over 2 years ago
- Assignee changed from Roman Kučera to Peter Štrunc
Can you release it please?
Updated by Peter Štrunc over 2 years ago
- Target version changed from 3.6.0 to 3.6.1
Updated by Roman Kučera over 2 years ago
- Status changed from In Progress to Needs feedback
- % Done changed from 80 to 90
@sourek Please look at this new PR https://github.com/bcvsolutions/czechidm-extras/pull/85
I fixed the test and added one condition into LRT to prevent null pointer, which sometimes occurs in tests.
Updated by Peter Štrunc over 2 years ago
- Status changed from Needs feedback to Resolved
- % Done changed from 90 to 100
LGTM merged to develop