Feature #3160
closed
Connect synchronization mapping with provisioning mapping by account type
100%
Description
Mapping for synchronization needs to be improved, because we will need to specify which provisioning mapping will be used for synchronized entities (could be also empty)
Synchronization is now relying on one provisioning mapping
Related issues
Updated by Roman Kučera over 2 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 70
Implementation in https://github.com/bcvsolutions/CzechIdMng/tree/kucerar/3160-relation-sync-mapping-prov-mapping
Implemented BE and FE.
Tested:- sync with create will use the selected mapping and save it to account
- update with ignore do nothing
- update when differential sync is turned of or if something changed mapping ID in account is set to the one which is configured in synced mapping
- tests
fix that mapping relation can be set after provisioning is saved.add validation to BE that you can make relation only between provisioning a synchronization mappings and vice versa.
Updated by Roman Kučera over 2 years ago
- Sprint set to Sprint 12.3-1 (Aug 03 - Aug 17)
Updated by Roman Kučera over 2 years ago
Draft PR https://github.com/bcvsolutions/CzechIdMng/pull/248
Review #3161 first and merge to devel, because this is based on that branch
Implemented business logic so the relation between connected mappings is updated on both sides, it's also deleted correctly.
Added new logic into entity to uuid converter, because it could end up in infinite loop if embedded attribute is same DTO type as parent. In this case embedded is not filled.
Github action is runnig.
TODO- implement some new tests to cover new use cases. Coverage is there already :)
Updated by Roman Kučera over 2 years ago
- Due date set to 06/28/2022
- Start date changed from 06/27/2022 to 06/28/2022
- Follows Feature #3161: Support for multiple provisioning mappings added
Updated by Roman Kučera over 2 years ago
- Precedes Feature #3159: Add support for account type in provisioning mapping configuration added
Updated by Roman Kučera over 2 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Roman Kučera to Tomáš Doischer
- % Done changed from 80 to 90
New tests implemented.
Github action pass.
Updated by Tomáš Doischer over 2 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Tomáš Doischer to Roman Kučera
Looks and works great, just found one issue, please check the PR.
Updated by Tomáš Doischer over 2 years ago
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100
I take it back, I missed an if.
LGTM, merged to develop.
Updated by Tomáš Doischer almost 2 years ago
- Status changed from Resolved to Closed