IdStory Identity Manager

Implemented. I also added a technical accounts agenda and ported bulk actions from accounts.

PRs:
https://github.com/bcvsolutions/CzechIdMng/pull/263
https://git.bcvsolutions.eu/modules/technical-accounts/-/merge_requests/2

Once the tests pass, it will be ready for review. The technical accounts are waiting for #3154 because a bulk action to provision technical account was added.

@kucerar, can you please give me feedback?

Code looks good, filters works nicely, thx

Clicking on column name for sorting end with system error (uid work once then brokes, some other columns broke after first click)

It looks like there are some cross joins

Filter by system on persnola tab

select
        generatedAlias0 
    from
        AccAccount as generatedAlias0 
    left join
        generatedAlias0.systemEntity as generatedAlias1 
    where
        (
            generatedAlias0.system.id in (
                :param0
            ) 
        ) 
        and (
            generatedAlias0.systemMapping.accountType=:param1 
        ) 
        and (
            1=1 
        ) 
    order by
        generatedAlias1.uid asc */ select
            accaccount0_.id as id1_0_,
            accaccount0_.created as created2_0_,
            accaccount0_.creator as creator3_0_,
            accaccount0_.creator_id as creator_4_0_,
            accaccount0_.modified as modified5_0_,
            accaccount0_.modifier as modifier6_0_,
            accaccount0_.modifier_id as modifier7_0_,
            accaccount0_.original_creator as original8_0_,
            accaccount0_.original_creator_id as original9_0_,
            accaccount0_.original_modifier as origina10_0_,
            accaccount0_.original_modifier_id as origina11_0_,
            accaccount0_.realm_id as realm_i12_0_,
            accaccount0_.transaction_id as transac13_0_,
            accaccount0_.end_of_protection as end_of_14_0_,
            accaccount0_.entity_type as entity_15_0_,
            accaccount0_.external_id as externa16_0_,
            accaccount0_.form_definition_id as form_de19_0_,
            accaccount0_.in_protection as in_prot17_0_,
            accaccount0_.system_id as system_20_0_,
            accaccount0_.system_entity_id as system_21_0_,
            accaccount0_.system_mapping_id as system_22_0_,
            accaccount0_.uid as uid18_0_ 
        from
            acc_account accaccount0_ 
        left outer join
            sys_system_entity syssysteme1_ 
                on accaccount0_.system_entity_id=syssysteme1_.id cross 
        join
            sys_system_mapping syssystemm2_ 
        where
            accaccount0_.system_mapping_id=syssystemm2_.id 
            and (
                accaccount0_.system_id in (
                    ?
                )
            ) 
            and syssystemm2_.account_type=? 
            and 1=1 
        order by
            syssysteme1_.uid asc limit ?

Plain filter, personal account agenda

select
        count(generatedAlias0) 
    from
        AccAccount as generatedAlias0 
    where
        (
            generatedAlias0.systemMapping.accountType=:param0 
        ) 
        and (
            1=1 
        ) */ select
            count(accaccount0_.id) as col_0_0_ 
        from
            acc_account accaccount0_ cross 
        join
            sys_system_mapping syssystemm1_ 
        where
            accaccount0_.system_mapping_id=syssystemm1_.id 
            and syssystemm1_.account_type=? 
            and 1=1

Personal acc, filter by role

select
        generatedAlias0 
    from
        AccAccount as generatedAlias0 
    left join
        generatedAlias0.systemEntity as generatedAlias1 
    where
        (
            exists (
                select
                    generatedAlias2 
                from
                    AccIdentityAccount as generatedAlias2 
                where
                    (
                        generatedAlias2.account=generatedAlias0 
                    ) 
                    and (
                        exists (
                            select
                                generatedAlias3 
                            from
                                IdmIdentityRole as generatedAlias3 
                            where
                                (
                                    generatedAlias3.role.id in (
                                        :param0
                                    ) 
                                ) 
                                and (
                                    generatedAlias2.identityRole=generatedAlias3 
                                )
                        ) 
                    )
                ) 
        ) 
        and (
            generatedAlias0.systemMapping.accountType=:param1 
        ) 
        and (
            1=1 
        ) 
    order by
        generatedAlias1.uid asc */ select
            accaccount0_.id as id1_0_,
            accaccount0_.created as created2_0_,
            accaccount0_.creator as creator3_0_,
            accaccount0_.creator_id as creator_4_0_,
            accaccount0_.modified as modified5_0_,
            accaccount0_.modifier as modifier6_0_,
            accaccount0_.modifier_id as modifier7_0_,
            accaccount0_.original_creator as original8_0_,
            accaccount0_.original_creator_id as original9_0_,
            accaccount0_.original_modifier as origina10_0_,
            accaccount0_.original_modifier_id as origina11_0_,
            accaccount0_.realm_id as realm_i12_0_,
            accaccount0_.transaction_id as transac13_0_,
            accaccount0_.end_of_protection as end_of_14_0_,
            accaccount0_.entity_type as entity_15_0_,
            accaccount0_.external_id as externa16_0_,
            accaccount0_.form_definition_id as form_de19_0_,
            accaccount0_.in_protection as in_prot17_0_,
            accaccount0_.system_id as system_20_0_,
            accaccount0_.system_entity_id as system_21_0_,
            accaccount0_.system_mapping_id as system_22_0_,
            accaccount0_.uid as uid18_0_ 
        from
            acc_account accaccount0_ 
        left outer join
            sys_system_entity syssysteme1_ 
                on accaccount0_.system_entity_id=syssysteme1_.id cross 
        join
            sys_system_mapping syssystemm4_ 
        where
            accaccount0_.system_mapping_id=syssystemm4_.id 
            and (
                exists (
                    select
                        accidentit2_.id 
                    from
                        acc_identity_account accidentit2_ 
                    where
                        accidentit2_.account_id=accaccount0_.id 
                        and (
                            exists (
                                select
                                    idmidentit3_.id 
                                from
                                    idm_identity_role idmidentit3_ 
                                where
                                    (
                                        idmidentit3_.role_id in (
                                            ?
                                        )
                                    ) 
                                    and accidentit2_.identity_role_id=idmidentit3_.id
                            )
                        )
                    )
            ) 
            and syssystemm4_.account_type=? 
            and 1=1 
        order by
            syssysteme1_.uid asc limit ?

Thanks for the findings.

I couldn't replicate the problem with the sort, please try again.

The cross joins were caused by the account type, this is now fixed.

Tests are running but when they are finished, can you look at it again, please?

Cross joins are now gone, thx for fix.
Sorting issue is also gone.

LGTM, merged to develop

I need to do a review for the part on tech module :)

thx, LGTM, merged