Project

General

Profile

Actions
Copy link

Task #315

closed

Email templates

Added by Ondřej Kopr about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Messaging
Target version:
Citrine (7.3.0)
Start date:
02/20/2017
Due date:
% Done:

100%

Estimated time:
Owner:

Description

  • new entity with template - (email html/ sms text)
  • localization en, cs, ...,
  • implement logic send into NotificationManager.

?

Related issues

Related to IdStory Identity Manager - Defect #1994: Child notification not using the same parentRejectedRadek Tomiška12/11/2019

Actions
Related to IdStory Identity Manager - Defect #359: Templates detail fix editor with Apache velocityClosedRadek Tomiška04/05/2017

Actions
Copied from IdStory Identity Manager - Task #276: Notification templatesRejectedRadek Tomiška01/25/2017

Actions
Actions
Copy link
 #1

Updated by Ondřej Kopr about 7 years ago

Analyze:

  • entity contains: name, code, body, type (sms, email),
  • parameters (? another table with all parameters that can be used - FE )
Actions
Copy link
 #2

Updated by Ondřej Kopr about 7 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 30
Actions
Copy link
 #3

Updated by Ondřej Kopr about 7 years ago

  • Create entity with service, repository, filter - IdmNotificationTemplates,
  • create FE forms - table, detail,
  • connect velocity to new created service,
  • fix all notification manager send,
  • fix test.
Actions
Copy link
 #4

Updated by Ondřej Kopr about 7 years ago

  • % Done changed from 30 to 60
  • add new property for notification template - body: html, text; system_template,
  • show and hide guarded string for all notification (email, console, websocket), to log is save only asterix,
  • inetrface NotificationSender and implementation is not change, method are same,
  • add property IdmNotificationTemplate to IdmMessage,
  • if IdmMessage contain template is new message generate by this template.
Actions
Copy link
 #5

Updated by Ondřej Kopr about 7 years ago

from object IdmNotificationTemplate was removed level.

Please Radek check my current solutions on BE maybe FE? :D

Things to do: tests, documentation.

Actions
Copy link
 #6

Updated by Ondřej Kopr about 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
Actions
Copy link
 #7

Updated by Ondřej Kopr about 7 years ago

PS: next todo, in provisioning processor that send email with password is hardcode name of email template.

Actions
Copy link
 #8

Updated by Ondřej Kopr about 7 years ago

  • add automatically deploy system templates from resources. Get classpath* and iterate over all xml templates. XML structure will be described in documentation,
  • add basic wysiwyg buttons into rich text area (bold, italic, strikethrought, undo, rendo), component richTextArea is prepared for implement another wysiwyg buttons,
  • for component rich text area also added new props for advanced control buttons. (template parameters, insert buttons).

In this ticket also found and fix problem with automatically deploy and redeploy workflow from all classpath.

Actions
Copy link
 #9

Updated by Radek Tomiška about 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
I did test and review:
  • text and html message will have greater priority than template texts (remove buildWithoutTemplate flag)
  • text and html message could be velocity templates too
  • when level is not given, then notification is not persisted
Actions
Copy link
 #10

Updated by Radek Tomiška about 7 years ago

  • Copied from Task #276: Notification templates added
Actions
Copy link
 #11

Updated by Ondřej Kopr about 7 years ago

  • % Done changed from 60 to 90
  • remove flag buildWithoutTemplate, build priority: template in configuration (by topic and level) < template in message < text from message,
  • user defined text, html and subject is now evaluate by template if template exists.
Actions
Copy link
 #12

Updated by Ondřej Kopr about 7 years ago

DOC: https://proj.bcvsolutions.eu/ngidm/doku.php?id=navrh:notification#sablony

Radek, please make me code review thank you :).

Actions
Copy link
 #13

Updated by Ondřej Kopr about 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
Actions
Copy link
 #14

Updated by Ondřej Kopr about 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 70
Actions
Copy link
 #15

Updated by Ondřej Kopr about 7 years ago

issues from FM and some minor fixes:

Please can you continue with review, thank you :).

Actions
Copy link
 #16

Updated by Ondřej Kopr about 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 70 to 90
Actions
Copy link
 #17

Updated by Radek Tomiška about 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
I did test and review. Templates are awesome, i found just few issues:
  • use ConfigurationService instead enviromnent
  • add focus to code, when template detail is open
  • filter on templates does not work - please implode all filtre fields to one quick text field (name or code or subject ...)
  • documentation:
    • code block is broken
    • change sentence with "... upset them ..." please :)
  • notification configuration table is not refreshed after configuraction is changed - NotificationConfigurationDto could extend Abstract dto - then refresh will work automatically
  • referential integrity - duplicit configuration with no level defined could be saved - please add check to business logic
  • notification log detail without template is broken - ..._embedded is not defined
  • AbstractNotificationSender:
    • refactor find template by configuration - will be method in template service
    • error to log only, when message is not defined
Actions
Copy link
 #18

Updated by Ondřej Kopr about 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška

Thank you for your feedback, solutions:

  • use ConfigurationService instead enviromnent - changed,
  • add focus to code, when template detail is open - OK (change from name to code),
  • fix documentation,
  • filter on templates was fixed,
  • into service notification configuration (method save) was added check to referential integrity,
  • fix reloading notification configuration table
  • notification log detail was fixed,
  • sender was refactor.

Thank you for feedback.

Actions
Copy link
 #19

Updated by Radek Tomiška about 7 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

Its awesome! I've just added focus to code, when template detail is open (init method isn't called).

Actions
Copy link
 #20

Updated by Radek Tomiška almost 4 years ago

  • Related to Defect #1994: Child notification not using the same parent added
Actions
Copy link
 #21

Updated by Radek Tomiška over 3 years ago

  • Related to Defect #359: Templates detail fix editor with Apache velocity added
Actions
Copy link

Also available in: Atom PDF