Project

General

Profile

Actions
Copy link

Defect #3028

closed

Misleading parameter in Remove automatic role task

Added by Alena Peterová over 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Low
Assignee:
Tomáš Doischer
Category:
Automatic roles
Target version:
13.0.0
Start date:
01/05/2022
Due date:
% Done:

80%

Estimated time:
Affected versions:
11.2.1
Owner:

Description

Tested on 11.2.1
When removing an automatic role by organizational structure, the task RemoveAutomaticRoleTaskExecutor contains misleading information - it displays the UID of the removed role in the parameter "Or: Automatic role by attribute" and "Automatic role by tree structure" is empty. It should be the opposite.

Files

automatic_role_tree.png (60.6 KB) automatic_role_tree.png Alena Peterová, 01/05/2022 09:06 AM
Actions
Copy link
 #1

Updated by Peter Štrunc about 2 years ago

  • Target version set to 12.2.0
Actions
Copy link
 #2

Updated by Roman Kučera almost 2 years ago

  • Target version changed from 12.2.0 to 13.0.0
Actions
Copy link
 #3

Updated by Tomáš Doischer almost 2 years ago

  • Status changed from New to In Progress
  • Assignee changed from Peter Štrunc to Tomáš Doischer
Actions
Copy link
 #4

Updated by Tomáš Doischer almost 2 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Tomáš Doischer to Roman Kučera
  • % Done changed from 0 to 80

This was interesting because the issue is caused by the way that form attributes are mapped when calling 'formInstance.getMappedAttributeByCode'. The mapping is done by id which is null in this case so the records would always be rewritten. As a result, a wrong form attribute (i. e., the second one, which is the one for the automatic role by attribute) would be used.

I don't think this is generally a problem (let alone one I can fix easily). To fix it here, I added a custom method for getting the form attribute from the form definition directly (which has lower space and time complexity than the original).

PR: https://github.com/bcvsolutions/CzechIdMng/pull/216

@kucerar, can you please give me feedback?

Actions
Copy link
 #5

Updated by Roman Kučera almost 2 years ago

  • Status changed from Needs feedback to Resolved

Thx, merged to develop

Actions
Copy link
 #6

Updated by Roman Kučera almost 2 years ago

  • Assignee changed from Roman Kučera to Tomáš Doischer
Actions
Copy link
 #7

Updated by Tomáš Doischer about 1 year ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF