Project

General

Profile

Actions

Defect #3016

closed

Provisionining archive - false is displayed as empty value

Added by Alena Peterová over 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomáš Doischer
Category:
Provisioning
Target version:
Start date:
12/07/2021
Due date:
% Done:

90%

Estimated time:
Affected versions:
Owner:

Description

Tested on 11.2.3 and 11.2.1
Changes in the boolean attribute (e.g. when disabling an account) displays "false" incorrectly as empty space in the provisioning archive, see:


Files

Actions #1

Updated by Peter Štrunc about 2 years ago

  • Target version set to 12.2.0
Actions #2

Updated by Roman Kučera almost 2 years ago

  • Target version changed from 12.2.0 to 13.0.0
Actions #3

Updated by Tomáš Doischer almost 2 years ago

  • Status changed from New to In Progress
  • Assignee changed from Peter Štrunc to Tomáš Doischer
Actions #4

Updated by Tomáš Doischer almost 2 years ago

  • % Done changed from 0 to 30

This is not a frontend issue - the false value for Boolean is represented as null in IcAttribute. I have to find the right place to fix it.

Actions #5

Updated by Tomáš Doischer almost 2 years ago

  • % Done changed from 30 to 70

I have made a change on the backend where the empty Boolean value is now translated to false. On the frontend, I had to change the basic null checking to comparison with undefined.

This seems to work well during testing. I tested it with a virtual system and a PostgreSQL table. There are some caveats:

  1. this will not work retroactively but only for new provisionings
  2. for a virtual system, the attribute type has to be Boolean - both in the schema and in the form definition. This one I'm worried about because it will not be backward compatible. By default, you can now add a new attribute to a virtual system and only set it as Boolean in the schema, let it be Text in the form definition and everything will work fine. This will change because it will fail now. After an upgrade, those who added their custom attributes for virtual systems and set them to type Boolean will see failures in provisioning and will need to manually change the attribute type in the form definition. I don't see any way that we can prevent that. The one good news is that this will not be a problem for the ENABLE attribute.

We will discuss it before a review.

PR: https://github.com/bcvsolutions/CzechIdMng/pull/218

@kucerar, can you give me feedback please?

Actions #6

Updated by Roman Kučera almost 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 70 to 90

LGTM, works nicely.

Changelog is updated to.

Actions #7

Updated by Tomáš Doischer about 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF